types(python): Slack Integration Types #28236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -149,7 +151,7 @@ def map_discover_query_args(url: str, args: Mapping[str, str]) -> Mapping[str, A | |||
| return dict(**args, query=query) | |||
|
|
|||
|
|
|||
| handler = Handler( | |||
| handler: Handler = Handler( | |||
There was a problem hiding this comment.
I hate how explicit mypy forces you to be. Like.. can it really not figure out for itself that this variable is a Handler?
There was a problem hiding this comment.
It's weird, when I take out the explicit typing in the three handlers I only get two errors:
src/sentry/integrations/slack/unfurl/__init__.py:46: error: Cannot determine type of 'handler'
src/sentry/integrations/slack/unfurl/__init__.py:48: error: Cannot determine type of 'handler'
There was a problem hiding this comment.
Nah it's just because mypy isn't very good 😢
1cf9e83 to
d6942df
Compare
d6942df to
c8f298b
Compare
wedamija
approved these changes
Sep 1, 2021
| @@ -116,8 +119,8 @@ def get_pipeline_views(self): | |||
|
|
|||
| return [identity_pipeline_view] | |||
|
|
|||
| def get_team_info(self, access_token): | |||
| headers = {"Authorization": "Bearer %s" % access_token} | |||
| def get_team_info(self, access_token: str) -> Any: | |||
| workspace = forms.ChoiceField(choices=(), widget=forms.Select()) | ||
| channel = forms.CharField(widget=forms.TextInput()) | ||
| channel_id = forms.HiddenInput() | ||
| tags = forms.CharField(required=False, widget=forms.TextInput()) | ||
|
|
||
| def __init__(self, *args, **kwargs): | ||
| def __init__(self, *args: Any, **kwargs: Any) -> None: |
There was a problem hiding this comment.
Should we type args/kwargs as Seq/Mapping?
| value = self._format_value(status, rule_id, error_message) | ||
| self.client.set(self._get_redis_key(), f"{value}", ex=60 * 60) | ||
|
|
||
| def get_value(self): | ||
| def get_value(self) -> Any: |
There was a problem hiding this comment.
We could use sentry.utils.json.JSONData. It's just Any for now, but if we want to change how we define json in the future this will make it easier.
9ea7560 to
f5e0cfe
Compare
jan-auer
added a commit
that referenced
this pull request
Sep 2, 2021
* master: (109 commits) ref(js): Add notice to use useApi when applicable (#28365) fix(tests): Temporarily disable test for migration 0223 (#28363) fix(ui): Use theme border for form footer border (#28359) ref(ts): Authenticators have names (#28362) feat(cdc_search): Implement cdc search for `is:unresolved` query. (#28006) ref(rrweb): Upgrade to latest player (#28333) feat(issue-alerts): Add Sentry Apps Alert Rule Action as an Action (#28338) feat(notifications): Remove NotificationSettings when Slack is uninstalled (#28216) py38(django 2.2): bump django-crispy-forms to 1.8.1 (#28344) types(python): Slack Integration Types (#28236) ref(jira ac): Rm fk constraints from JiraTenant (#28349) chore(js): Upgrade storybook from 6.3.6 -> 6.3.7 (#28323) feat(symbol-sources): Redact symbol source secrets from audit logs (#28334) feat(notifications): Add `actor_id` to Analytics Events (#28347) ref(performance): Separate header from content in transaction events (#28346) Adding in new text styles for the codeowners sync CTA in the issues detail. (#28133) fix(django 2.2): rename view method to avoid clashing (#28312) fix(alerts): Project breadcrumb link to project rule list (#28339) ref(performance): Separate header from content in transaction vitals (#28343) feat(dev_env): Dev env bootstrap support for two Python versions (#28213) ...
shruthilayaj
pushed a commit
that referenced
this pull request
Sep 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding types to the
src/sentry/integrations/slack/directory. Some tricky things:__path__IntegrationMetadatais icky because it extends itself because of classes/namedtuplesparse_link()function should be refactored in a separate PR