feat(notifications): Remove NotificationSettings when Slack is uninstalled #28216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c54e9e to
3bba865
Compare
3bba865 to
d5aa17c
Compare
d6942df to
c8f298b
Compare
d5aa17c to
921636e
Compare
ceorourke
reviewed
Aug 31, 2021
src/sentry/testutils/factories.py
Outdated
| @staticmethod | ||
| def create_integration( | ||
| organization: Organization, provider: ExternalProviders, external_id: str, **kwargs: Any | ||
| ) -> Identity: |
There was a problem hiding this comment.
Is this right? It says you're returning an Identity but you are actually returning an Integration
There was a problem hiding this comment.
Also I don't know if it's too specific but I dont know that this would actually work for non-Slack integrations given the metadata, so you might want to just rename this create_slack_integration.
ceorourke
reviewed
Sep 1, 2021
5fbe0e5 to
ce10e1c
Compare
ceorourke
approved these changes
Sep 1, 2021
9ea7560 to
f5e0cfe
Compare
ce10e1c to
f347949
Compare
jan-auer
added a commit
that referenced
this pull request
Sep 2, 2021
* master: (109 commits) ref(js): Add notice to use useApi when applicable (#28365) fix(tests): Temporarily disable test for migration 0223 (#28363) fix(ui): Use theme border for form footer border (#28359) ref(ts): Authenticators have names (#28362) feat(cdc_search): Implement cdc search for `is:unresolved` query. (#28006) ref(rrweb): Upgrade to latest player (#28333) feat(issue-alerts): Add Sentry Apps Alert Rule Action as an Action (#28338) feat(notifications): Remove NotificationSettings when Slack is uninstalled (#28216) py38(django 2.2): bump django-crispy-forms to 1.8.1 (#28344) types(python): Slack Integration Types (#28236) ref(jira ac): Rm fk constraints from JiraTenant (#28349) chore(js): Upgrade storybook from 6.3.6 -> 6.3.7 (#28323) feat(symbol-sources): Redact symbol source secrets from audit logs (#28334) feat(notifications): Add `actor_id` to Analytics Events (#28347) ref(performance): Separate header from content in transaction events (#28346) Adding in new text styles for the codeowners sync CTA in the issues detail. (#28133) fix(django 2.2): rename view method to avoid clashing (#28312) fix(alerts): Project breadcrumb link to project rule list (#28339) ref(performance): Separate header from content in transaction vitals (#28343) feat(dev_env): Dev env bootstrap support for two Python versions (#28213) ...
shruthilayaj
pushed a commit
that referenced
this pull request
Sep 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user uninstalls Slack for their organization, we should turn off all of the parent-specific Slack notification settings for all users in the organization. If an affected user had only one organization with Slack installed, also delete their parent-independent Slack notification settings.