Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix): Don't create .sentrclirc if project uses Vite. #667

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

onurtemizkan
Copy link
Collaborator

Fixes: #664

We need .sentryclirc file for the projects that do not use Vite, where we update the build script in package.json to use sentry-upload-sourcemaps.

It is currently creating both for projects using Vite, so I moved it to where we update the build script instead.

@onurtemizkan onurtemizkan requested a review from Lms24 September 9, 2024 10:10
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@onurtemizkan onurtemizkan force-pushed the onur/remix-fix-multiple-auth-config branch from f573476 to 698e04c Compare September 9, 2024 13:24
@Lms24 Lms24 merged commit 140a324 into master Sep 9, 2024
13 checks passed
@Lms24 Lms24 deleted the onur/remix-fix-multiple-auth-config branch September 9, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remix Wizard creates .sentryclirc and .env.sentry-build-plugin
2 participants