Skip to content

Commit

Permalink
fix(remix): Don't create .sentrclirc if project uses Vite. (#667)
Browse files Browse the repository at this point in the history
  • Loading branch information
onurtemizkan authored Sep 9, 2024
1 parent 132439d commit 140a324
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- ref(nextjs): Adjust dev server command in verification message (#665)
- feat(remix): Add feature selection (#646)
- fix(remix): Don't create `.sentrclirc` if project uses Vite (#667)

## 3.28.0

Expand Down
4 changes: 2 additions & 2 deletions src/remix/remix-wizard.ts
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,6 @@ async function runRemixWizardWithTelemetry(
},
] as const);

await addSentryCliConfig({ authToken }, rcCliSetupConfig);

if (viteConfig) {
await traceStep(
'Update vite configuration for sourcemap uploads',
Expand Down Expand Up @@ -125,6 +123,8 @@ async function runRemixWizardWithTelemetry(
url: sentryUrl === DEFAULT_URL ? undefined : sentryUrl,
isHydrogen: isHydrogenApp(packageJson),
});

await addSentryCliConfig({ authToken }, rcCliSetupConfig);
} catch (e) {
clack.log
.warn(`Could not update build script to generate and upload sourcemaps.
Expand Down

0 comments on commit 140a324

Please sign in to comment.