fix(remix): Change handleError in server entry
#621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
requested changes
Jul 8, 2024
src/remix/templates.ts
Outdated
| export const HANDLE_ERROR_TEMPLATE_V2 = `function handleError(error, { request }) { | ||
| Sentry.captureRemixServerException(error, 'remix.server', request, true); | ||
| } | ||
| export const HANDLE_ERROR_TEMPLATE_V2 = `export const handleError = Sentry.wrapHandleErrorWithSentry((error, { request }) => { |
There was a problem hiding this comment.
This generated the code below in my test app:
export export const handleError = Sentry.wrapHandleErrorWithSentry((error, { request }) => {
// Custom handleError implementation
});
We should remove the logic that:
exportsthe code in the template - handle-error.ts
- Or we can remove
exportfrom the template instead.
|
@s1gr1d - I updated the codemod to work on the new template. |
|
Looks good! Feel free to merge it after you accept it. I cannot accept as I opened the PR. |
onurtemizkan
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the produced code for
handleErrorbased on the docs.docs PR: getsentry/sentry-docs#10597
closes: getsentry/sentry-javascript#12785