Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix): Code example for handleError #10597

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Jul 8, 2024

DESCRIBE YOUR PR

Updates the code snippet for setting up the server error handler in Remix

related issue: getsentry/sentry-javascript#12785

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.): 9. July (asap, as example is wrong)
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

codecov bot commented Jul 8, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes ⬇️

Bundle name Size Change
sentry-docs-server 8.29MB 6 bytes ⬇️
sentry-docs-edge-server 249.71kB 3 bytes ⬇️
sentry-docs-client 7.87MB 6 bytes ⬇️

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 8:56am

@s1gr1d s1gr1d merged commit d3c7939 into master Jul 8, 2024
7 checks passed
@s1gr1d s1gr1d deleted the sig/remix-fix-errorHandler branch July 8, 2024 09:33
sentrivana pushed a commit that referenced this pull request Jul 16, 2024
* fix(remix): Code example for `handleError`

* add function params
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants