Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Write SampleRate as float to manifest #1872

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Conversation

bitsandfoxes
Copy link
Contributor

Fixes #1871

@bitsandfoxes bitsandfoxes requested a review from vaind October 30, 2024 15:53
Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this issue getsentry/sentry-java#3603 which has already been addressed and should come out in the next sentry-java release.

I don't see why merging this would hurt though.

@bitsandfoxes bitsandfoxes merged commit 2f6285a into main Oct 31, 2024
13 checks passed
@bitsandfoxes bitsandfoxes deleted the fix/android-sample-rate branch October 31, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning due to SampleRate passed on to Android as int
2 participants