Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android manifest int/float parsing #3603

Closed
vaind opened this issue Jul 24, 2024 · 1 comment · Fixed by #3823
Closed

Android manifest int/float parsing #3603

vaind opened this issue Jul 24, 2024 · 1 comment · Fixed by #3823
Assignees
Labels
Platform: Android Type: Bug Something isn't working

Comments

@vaind
Copy link
Collaborator

vaind commented Jul 24, 2024

Integration

sentry-android

Build System

Gradle

AGP Version

n/a

Proguard

Enabled

Version

7.12.0

Steps to Reproduce

Add <meta-data android:name="io.sentry.session-replay.session-sample-rate" android:value="1" /> to android manifest (this is what was output by a custom tooling that creates items programatically during build from a 1.0 double value after calling ToString() on it in c#

Expected Result

Recognizes 1 as 1.0

Actual Result

Key io.sentry.session-replay.session-sample-rate expected Float but value was a java.lang.Integer. The default value -1.0 was returned.

@markushi
Copy link
Member

@vaind thanks for reporting! Let's ensure we fix this for all attributes where we expect float values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Android Type: Bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants