-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(native): Add react-native
postfix to native SDKs
#2814
Conversation
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
15c80ab+dirty | 1248.41 ms | 1251.24 ms | 2.83 ms |
70caa60+dirty | 1279.08 ms | 1281.54 ms | 2.46 ms |
52a8031+dirty | 1255.96 ms | 1273.00 ms | 17.04 ms |
e73f4ed+dirty | 1282.90 ms | 1309.30 ms | 26.40 ms |
8900e1a+dirty | 1268.36 ms | 1273.04 ms | 4.68 ms |
76d1baf+dirty | 1245.00 ms | 1257.76 ms | 12.76 ms |
d0bf494+dirty | 1266.20 ms | 1267.52 ms | 1.32 ms |
86d6d2c+dirty | 1291.62 ms | 1296.80 ms | 5.18 ms |
d7401ac+dirty | 1288.10 ms | 1289.54 ms | 1.44 ms |
9a3ca65+dirty | 1276.40 ms | 1279.14 ms | 2.74 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
15c80ab+dirty | 2.92 MiB | 3.39 MiB | 481.56 KiB |
70caa60+dirty | 2.92 MiB | 3.39 MiB | 486.04 KiB |
52a8031+dirty | 2.92 MiB | 3.38 MiB | 475.71 KiB |
e73f4ed+dirty | 2.92 MiB | 3.38 MiB | 475.71 KiB |
8900e1a+dirty | 2.92 MiB | 3.39 MiB | 485.96 KiB |
76d1baf+dirty | 2.92 MiB | 3.38 MiB | 475.74 KiB |
d0bf494+dirty | 2.92 MiB | 3.40 MiB | 488.08 KiB |
86d6d2c+dirty | 2.92 MiB | 3.37 MiB | 464.31 KiB |
d7401ac+dirty | 2.92 MiB | 3.40 MiB | 488.06 KiB |
9a3ca65+dirty | 2.92 MiB | 3.37 MiB | 464.32 KiB |
Android (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
15c80ab+dirty | 276.38 ms | 327.54 ms | 51.17 ms |
70caa60+dirty | 308.83 ms | 393.06 ms | 84.23 ms |
52a8031+dirty | 330.72 ms | 358.76 ms | 28.03 ms |
e73f4ed+dirty | 262.98 ms | 311.02 ms | 48.04 ms |
8900e1a+dirty | 371.40 ms | 377.70 ms | 6.31 ms |
76d1baf+dirty | 339.02 ms | 408.65 ms | 69.63 ms |
d0bf494+dirty | 253.73 ms | 308.23 ms | 54.49 ms |
86d6d2c+dirty | 267.21 ms | 325.24 ms | 58.04 ms |
d7401ac+dirty | 373.98 ms | 394.08 ms | 20.10 ms |
9a3ca65+dirty | 344.96 ms | 358.92 ms | 13.96 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
15c80ab+dirty | 7.15 MiB | 8.09 MiB | 966.13 KiB |
70caa60+dirty | 7.15 MiB | 8.03 MiB | 901.79 KiB |
52a8031+dirty | 7.15 MiB | 8.09 MiB | 965.95 KiB |
e73f4ed+dirty | 7.15 MiB | 8.09 MiB | 965.94 KiB |
8900e1a+dirty | 7.15 MiB | 8.03 MiB | 901.79 KiB |
76d1baf+dirty | 7.15 MiB | 8.09 MiB | 964.41 KiB |
d0bf494+dirty | 7.15 MiB | 8.04 MiB | 910.85 KiB |
86d6d2c+dirty | 7.15 MiB | 8.09 MiB | 962.69 KiB |
d7401ac+dirty | 7.15 MiB | 8.04 MiB | 910.85 KiB |
9a3ca65+dirty | 7.15 MiB | 8.09 MiB | 962.83 KiB |
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
15c80ab+dirty | 336.27 ms | 350.58 ms | 14.31 ms |
70caa60+dirty | 299.00 ms | 321.02 ms | 22.02 ms |
52a8031+dirty | 311.55 ms | 321.37 ms | 9.82 ms |
e73f4ed+dirty | 332.96 ms | 354.33 ms | 21.37 ms |
8900e1a+dirty | 430.68 ms | 456.13 ms | 25.44 ms |
76d1baf+dirty | 335.72 ms | 355.52 ms | 19.80 ms |
d0bf494+dirty | 375.37 ms | 395.14 ms | 19.77 ms |
86d6d2c+dirty | 332.90 ms | 352.45 ms | 19.55 ms |
d7401ac+dirty | 375.20 ms | 383.51 ms | 8.31 ms |
9a3ca65+dirty | 326.93 ms | 330.14 ms | 3.21 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
15c80ab+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
70caa60+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
52a8031+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
e73f4ed+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
8900e1a+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
76d1baf+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
d0bf494+dirty | 17.73 MiB | 19.75 MiB | 2.02 MiB |
86d6d2c+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
d7401ac+dirty | 17.73 MiB | 19.75 MiB | 2.02 MiB |
9a3ca65+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d091239+dirty | 1251.49 ms | 1276.75 ms | 25.26 ms |
d760caf+dirty | 1266.80 ms | 1290.92 ms | 24.12 ms |
b868b53+dirty | 1274.90 ms | 1305.68 ms | 30.78 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d091239+dirty | 2.36 MiB | 2.74 MiB | 384.64 KiB |
d760caf+dirty | 2.36 MiB | 2.81 MiB | 462.03 KiB |
b868b53+dirty | 2.36 MiB | 2.74 MiB | 384.64 KiB |
We need to check this getsentry/develop#832 |
Yes. I understand the same.
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
@krystofwoldrich I believe we can easily fix this since it's possible to do on iOS and Android, right? you can check Flutter. |
@marandaneto Yes. |
@krystofwoldrich dont forget to ping @kahest and the data team about updating the SDK family sheet. |
react-native
postfix to native SDKs
📢 Type of change
📜 Description
Set's RN SDK name and version to the Native SDKs.
💡 Motivation and Context
sentryClientName
on Native SDKs during SDK init. team-mobile#48💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps
blocked by:HintUtils.isFromHybridSdk
andHintUtils.setIsFromHybridSdk
should use hints instead sentry-java#2525#skip-changelog