Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the sentryClientName on Native SDKs during SDK init #2813

Closed
Tracked by #48
krystofwoldrich opened this issue Feb 8, 2023 · 2 comments · Fixed by #2814
Closed
Tracked by #48

Set the sentryClientName on Native SDKs during SDK init #2813

krystofwoldrich opened this issue Feb 8, 2023 · 2 comments · Fixed by #2814
Assignees
@krystofwoldrich
Labels
Platform: React-Native

Comments

@krystofwoldrich
Copy link
Member

Description

RN should set sentry.javascript.react-native name on Native SDKs.
@krystofwoldrich krystofwoldrich added Platform: React-Native Breaking-change should go in a major release (breaks apps, changes default configs in a major way) labels Feb 8, 2023
@krystofwoldrich krystofwoldrich added this to the 5.0.0 milestone Feb 8, 2023
@krystofwoldrich krystofwoldrich self-assigned this Feb 8, 2023
@github-project-automation github-project-automation bot moved this to Needs Discussion in Mobile & Cross Platform SDK Feb 8, 2023
@krystofwoldrich krystofwoldrich mentioned this issue Feb 8, 2023
Closed
@krystofwoldrich krystofwoldrich moved this from Needs Discussion to In Progress in Mobile & Cross Platform SDK Feb 8, 2023
@krystofwoldrich krystofwoldrich mentioned this issue Feb 8, 2023
Merged
9 tasks
@krystofwoldrich krystofwoldrich removed this from the 5.0.0 milestone Feb 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@krystofwoldrich krystofwoldrich removed the Breaking-change should go in a major release (breaks apps, changes default configs in a major way) label Mar 17, 2023
@krystofwoldrich
Copy link
Member Author

We also need to pass a new name to the native SDK. This needs an exposed method on Android and iOS to set the name.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Mobile & Cross Platform SDK Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krystofwoldrich krystofwoldrich

Labels
Platform: React-Native
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(native): Add react-native postfix to native SDKs getsentry/sentry-react-native
2 participants
@marandaneto @krystofwoldrich