Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle PhantomJS 1.x file:/// urls #642

Merged
merged 2 commits into from
Jul 7, 2016
Merged

Handle PhantomJS 1.x file:/// urls #642

merged 2 commits into from
Jul 7, 2016

Conversation

benvinegar
Copy link
Contributor

@benvinegar benvinegar commented Jul 7, 2016

I discovered that we were dropping frames from PhantomJS – specifically those without method names and begining with file:///

cc @mattrobenolt


This change is Reviewable

@benvinegar
Copy link
Contributor Author

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.


test/vendor/tracekit-parser.test.js, line 269 [r1] (raw file):

            var stackFrames = TraceKit.computeStackTrace(CapturedExceptions.PHANTOMJS_1_19);
            assert.ok(stackFrames);
            assert.deepEqual(stackFrames.stack.length, 3);

Oops, forgot some assertions here


Comments from Reviewable

@benvinegar benvinegar merged commit 879ec45 into master Jul 7, 2016
@benvinegar benvinegar deleted the fix-phantomjs-file branch July 7, 2016 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant