Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drops function-less frames from PhantomJS 1.x stacks #3649

Closed
benvinegar opened this issue Jul 6, 2016 · 1 comment
Closed

Drops function-less frames from PhantomJS 1.x stacks #3649

benvinegar opened this issue Jul 6, 2016 · 1 comment

Comments

@benvinegar
Copy link
Contributor

Discovered while working on unit tests for #582

Given this stack trace (from our unit tests):

  Error: foo
    at file:///Users/benvinegar/Projects/raven-js/build/raven.test.js:878
    at foo (file:///Users/benvinegar/Projects/raven-js/build/raven.test.js:4283)
    at file:///Users/benvinegar/Projects/raven-js/build/raven.test.js:4287
    at callFn (file:///Users/benvinegar/Projects/raven-js/node_modules/mocha/mocha.js:4452)
    at file:///Users/benvinegar/Projects/raven-js/node_modules/mocha/mocha.js:4445
    at file:///Users/benvinegar/Projects/raven-js/node_modules/mocha/mocha.js:4847
    at file:///Users/benvinegar/Projects/raven-js/node_modules/mocha/mocha.js:4938
    at next (file:///Users/benvinegar/Projects/raven-js/node_modules/mocha/mocha.js:4772)
    at file:///Users/benvinegar/Projects/raven-js/node_modules/mocha/mocha.js:4782
    at next (file:///Users/benvinegar/Projects/raven-js/node_modules/mocha/mocha.js:4720)
    at file:///Users/benvinegar/Projects/raven-js/node_modules/mocha/mocha.js:4749
    at timeslice (file:///Users/benvinegar/Projects/raven-js/node_modules/mocha/mocha.js:6015)

Every frame without parents/function names is dropped entirely.

@benvinegar
Copy link
Contributor Author

Laugh – wrong project, but this was fixed anyways in getsentry/sentry-javascript#642

@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant