Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v8/browser): Add multiplexedtransport.js CDN bundle (#15043) #15046

Merged
merged 1 commit into from
Jan 17, 2025
Merged

feat(v8/browser): Add multiplexedtransport.js CDN bundle (#15043) #15046

merged 1 commit into from
Jan 17, 2025
+67 −1

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 17, 2025 •
edited
Loading

v8 backport of #15043

ref #15041

@Lms24 Lms24 requested review from lforst and mydea January 17, 2025 11:14
@Lms24 Lms24 self-assigned this Jan 17, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
630 2 628 300
View the top 1 failed tests by shortest run time 
replay/slowClick/windowOpen/test.ts window.open() is considered for slow click
Stack Traces | 2.46s run time 
test.ts:6:11 window.open() is considered for slow click
View the full list of 1 ❄️ flaky tests 
request-instrumentation.test.ts Should send a transaction with a fetch span

Flake rate in main: 36.36% (Passed 7 times, Failed 4 times)

Stack Traces | 30s run time 
request-instrumentation.test.ts:4:5 Should send a transaction with a fetch span

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@Lms24 Lms24 changed the title feat(browser): Add multiplexedtransport.js CDN bundle (#15043) feat(v8/browser): Add multiplexedtransport.js CDN bundle (#15043) Jan 17, 2025
@Lms24
feat(browser): Add multiplexedtransport.js CDN bundle (#15043)
205c792 
Add a pluggable CDN bundle for `makeMultiplexedTransport`, an
API we export from `@sentry/browser` but not from the browser SDK CDN
bundles for bundle size reasons.
@Lms24 Lms24 force-pushed the lms/v8-feat-browser-multiplexed-transport-bundle branch from cffe110 to 205c792 Compare January 17, 2025 13:43
@Lms24 Lms24 merged commit 2bc3584 into v8 Jan 17, 2025
124 checks passed
@Lms24 Lms24 deleted the lms/v8-feat-browser-multiplexed-transport-bundle branch January 17, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

@mydea mydea Awaiting requested review from mydea

Assignees

@Lms24 Lms24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lms24 @lforst