Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(browser): Add multiplexedtransport.js CDN bundle #15043

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 17, 2025

This PR adds a pluggable CDN bundle for makeMultiplexedTransport, an API we export from @sentry/browser but not from the browser SDK CDN bundles. After discussing #15041, we settled on avoiding to add the export to the bundle directly, as it would unnecessarily increase bundle size for the majority of our user base.

However, we'll enable using the multiplexed transport in a CDN bundle setup by publishing a pluggable addon bundle for this API that users can add just like our pluggable integration CDN bundles.

Will open a PR for docs in a bit

closes #15041
supersedes #14925

Copy link

codecov bot commented Jan 17, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
626 1 625 298
View the top 1 failed tests by shortest run time
transport/multiplexed/test.ts sends event to DSNs specified in makeMultiplexedTransport
Stack Traces | 30s run time
test.ts:7:11 sends event to DSNs specified in makeMultiplexedTransport

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@Lms24 Lms24 merged commit 4af179e into develop Jan 17, 2025
125 checks passed
@Lms24 Lms24 deleted the lms/feat-browser-cdb-multiplexed-transport branch January 17, 2025 11:12
Lms24 added a commit that referenced this pull request Jan 17, 2025
Add a pluggable CDN bundle for `makeMultiplexedTransport`, an
API we export from `@sentry/browser` but not from the browser SDK CDN
bundles for bundle size reasons.
Lms24 added a commit that referenced this pull request Jan 17, 2025
Add a pluggable CDN bundle for `makeMultiplexedTransport`, an
API we export from `@sentry/browser` but not from the browser SDK CDN
bundles for bundle size reasons.
Lms24 added a commit that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

makeMultiplexedTransport and makeFetchTransport not available in the CDN import
2 participants