-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve HTTP Proxy parameters from the external configuration. #1035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #1035 +/- ##
============================================
- Coverage 71.98% 71.98% -0.01%
- Complexity 1322 1336 +14
============================================
Files 135 138 +3
Lines 4816 4880 +64
Branches 492 499 +7
============================================
+ Hits 3467 3513 +46
- Misses 1091 1106 +15
- Partials 258 261 +3
Continue to review full report at Codecov.
|
@maciejwalkowiak this is ready to be merged, right? let's do it so we include it in the release next week. |
📢 Type of change
📜 Description
Resolve HTTP Proxy parameters from the external configuration.
In order to make Proxy properties resolution in non-Spring Boot application the same as in Spring Boot application, the names of the environment variables had to be changed from ones in 1.7.x
SENTRY_PROXY_HOST
SENTRY_PROXY_PORT
SENTRY_PROXY_USER
SENTRY_PROXY_PASS
In addition to that -
SentryOptions#proxy
object had to be changed into Java bean so that we are able to bind properties via Spring Boot environment.💡 Motivation and Context
Fixes #1028
💚 How did you test it?
Unit tests.
📝 Checklist