Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java docs update #2708

Merged
merged 5 commits into from
Nov 24, 2020
Merged

Java docs update #2708

merged 5 commits into from
Nov 24, 2020

Conversation

maciejwalkowiak
Copy link
Contributor

@vercel
Copy link

vercel bot commented Nov 23, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/qacwuq4te/sentry.dev
✅ Preview: https://sentry-docs-git-java-docs-update.sentry.dev

@maciejwalkowiak
Copy link
Contributor Author

cc @marandaneto @bruno-garcia

@marandaneto marandaneto requested a review from a team November 23, 2020 09:19
marandaneto
marandaneto approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks for this.

@pantos27
Copy link

What about performance monitoring docs for Java?

@maciejwalkowiak @marandaneto
Update src/platforms/java/common/configuration/index.mdx
ea17fce 
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
@maciejwalkowiak
Copy link
Contributor Author

@pantos27 this will come next.

bruno-garcia
bruno-garcia approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@bruno-garcia bruno-garcia merged commit a4f5ffe into getsentry:master Nov 24, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@marandaneto marandaneto marandaneto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maciejwalkowiak @pantos27 @bruno-garcia @marandaneto