Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove warning about relative urls for chunk uploads #1054

Merged
merged 1 commit into from
Oct 21, 2021
Merged

ref: Remove warning about relative urls for chunk uploads #1054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/utils/chunks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,12 @@ use std::sync::Arc;
use std::time::Duration;

use failure::Error;
use log::warn;
use parking_lot::RwLock;
use rayon::prelude::*;
use rayon::ThreadPoolBuilder;
use sha1::Digest;

use crate::api::{Api, ChunkUploadOptions, ProgressBarMode};
use crate::utils::http::is_absolute_url;
use crate::utils::progress::{ProgressBar, ProgressStyle};

/// Timeout for polling all assemble endpoints.
Expand Down Expand Up @@ -208,11 +206,6 @@ pub fn upload_chunks(
.num_threads(chunk_options.concurrency as usize)
.build()?;

if !is_absolute_url(&chunk_options.url) {
warn!("Uploading chunks to a relative url is not recommended. Please update your `system.url-prefix`\
configuration inside `config.yml` or use `Root URL` option at https://<sentry-url>/manage/settings/ directly.");
}

pool.install(|| {
batches
.into_par_iter()
Expand Down