Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove warning about relative urls for chunk uploads #1054

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

kamilogorek
Copy link
Contributor

It was introduced due to behavior explained here - #649 (comment)
However since then, we changed how the endpoint is exposed from Sentry, so we do handle relative URLs correctly - getsentry/sentry#29347

Fixes #1051
Fixes getsentry/sentry-webpack-plugin#325

Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That we missed. It's a bit unfortunate, because changing this URL now issues a warning for every sentry-cli user. Can we maybe gate the relative URL on the chuck options endpoint behind a user-agent check for the right version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting "Uploading chunks to a relative url is not recommended" warning out of the blue. Unexpected Warning
2 participants