Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Vue projects weren't able to reference the VUE app. #559

Merged
merged 6 commits into from
Jan 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,16 @@ node_modules/
coverage/

# example files
example/ionic-angular*/dist
example/ionic-angular*/node_modules
example/ionic-angular*/platforms
example/ionic-angular*/plugins
example/ionic-angular*/www
example/ionic-angular*/.gradle
example/ionic-angular*/build
example/ionic-angular*/.ionic
example/ionic-angular*/.yalc
example/ionic-angular*/.angular
example/*/dist
example/*/node_modules
example/*/platforms
example/*/plugins
example/*/www
example/*/.gradle
example/*/build
example/*/.ionic
example/*/.yalc
example/*/.angular

# iOS files
Pods
Expand Down Expand Up @@ -82,8 +82,8 @@ captures/
yalc.lock

android/gradle/wrapper/gradle-wrapper.properties
example/ionic-angular/android/capacitor.settings.gradle
example/ionic-angular/android/app/capacitor.build.gradle
example/*/android/capacitor.settings.gradle
example/*/android/app/capacitor.build.gradle

#yarn pack files
sentry-capacitor-v*.tgz
Expand Down
46 changes: 22 additions & 24 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,27 +1,25 @@
{
"editor.formatOnType": true,
"editor.formatOnType": true,
"editor.formatOnPaste": false,
"editor.formatOnSave": true,
"editor.rulers": [120],
"editor.tabSize": 2,
"files.autoSave": "onWindowChange",
"files.trimTrailingWhitespace": true,
"files.insertFinalNewline": true,
"search.exclude": {
"**/node_modules/": true,
"**/build/": true,
"**/dist/": true
},
"typescript.tsdk": "./node_modules/typescript/lib",
"editor.codeActionsOnSave": {
"source.fixAll": "explicit"
},
"[json]": {
"editor.formatOnType": false,
"editor.formatOnPaste": false,
"editor.formatOnSave": true,
"editor.rulers": [
120
],
"editor.tabSize": 2,
"files.autoSave": "onWindowChange",
"files.trimTrailingWhitespace": true,
"files.insertFinalNewline": true,
"search.exclude": {
"**/node_modules/": true,
"**/build/": true,
"**/dist/": true
},
"typescript.tsdk": "./node_modules/typescript/lib",
"editor.codeActionsOnSave": {
"source.fixAll": true
},
"[json]": {
"editor.formatOnType": false,
"editor.formatOnPaste": false,
"editor.formatOnSave": false
},
"files.eol": "\n"
"editor.formatOnSave": false
},
"files.eol": "\n"
}
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Fixes

- Vue projects weren't able to reference the VUE app ([#559](https://github.com/getsentry/sentry-capacitor/pull/559))

### Dependencies

- Bump JavaScript Sibling SDKs from v7.81.1 to v7.93.0 ([#527](https://github.com/getsentry/sentry-capacitor/pull/527))
Expand Down
26 changes: 13 additions & 13 deletions example/ionic-angular-v5/ios/App/Podfile.lock
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
PODS:
- Capacitor (5.0.4):
- Capacitor (5.5.1):
- CapacitorCordova
- CapacitorCordova (5.0.4)
- Sentry/HybridSDK (8.8.0):
- SentryPrivate (= 8.8.0)
- SentryCapacitor (0.12.3):
- CapacitorCordova (5.5.1)
- Sentry/HybridSDK (8.18.0):
- SentryPrivate (= 8.18.0)
- SentryCapacitor (0.15.0):
- Capacitor
- Sentry/HybridSDK (= 8.8.0)
- SentryPrivate (8.8.0)
- Sentry/HybridSDK (= 8.18.0)
- SentryPrivate (8.18.0)

DEPENDENCIES:
- "Capacitor (from `../../node_modules/@capacitor/ios`)"
Expand All @@ -28,12 +28,12 @@ EXTERNAL SOURCES:
:path: "../../node_modules/@sentry/capacitor"

SPEC CHECKSUMS:
Capacitor: d3d4463573438b9fa65326d1f3549da6f4c21634
CapacitorCordova: b1fe6bf1f36974a8e4a9044b342d22d49c0996d6
Sentry: 927dfb29d18a14d924229a59cc2ad149f43349f2
SentryCapacitor: 8721f0ada5dca84617870212988890d857aa8fdc
SentryPrivate: 4350d865f898224ab9fa02b37d6ee7fbb623f47e
Capacitor: 9da0a2415e3b6098511f8b5ffdb578d91ee79f8f
CapacitorCordova: e128cc7688c070ca0bfa439898a5f609da8dbcfe
Sentry: 8984a4ffb2b9bd2894d74fb36e6f5833865bc18e
SentryCapacitor: fdeb867d98fafcc00f52b4a730777dc7e6c0014b
SentryPrivate: 2f0c9ba4c3fc993f70eab6ca95673509561e0085

PODFILE CHECKSUM: 618eb4d85f9b0c9e5a37fffa86a92d1569bd6800

COCOAPODS: 1.11.3
COCOAPODS: 1.14.3
3 changes: 1 addition & 2 deletions example/ionic-angular-v5/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@
"@ionic-native/splash-screen": "^5.0.0",
"@ionic-native/status-bar": "^5.0.0",
"@ionic/angular": "^5.0.0",
"@sentry/angular-ivy": "7.81.1",
"@sentry/capacitor": "file:.yalc/@sentry/capacitor",
"@sentry/cli": "^2.21.3",
krystofwoldrich marked this conversation as resolved.
Show resolved Hide resolved
"@sentry/angular-ivy": "7.81.1",
"rxjs": "~6.5.5",
"tslib": "^2.0.0",
"zone.js": "~0.11.4"
Expand Down
53 changes: 48 additions & 5 deletions example/ionic-angular-v5/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1804,7 +1804,7 @@
"@sentry/utils" "7.81.1"

"@sentry/capacitor@file:.yalc/@sentry/capacitor":
version "0.14.0"
version "0.15.0"
dependencies:
"@sentry/browser" "7.81.1"
"@sentry/core" "7.81.1"
Expand All @@ -1814,16 +1814,59 @@
"@sentry/types" "7.81.1"
"@sentry/utils" "7.81.1"

"@sentry/cli@^2.21.3":
version "2.21.5"
resolved "https://registry.yarnpkg.com/@sentry/cli/-/cli-2.21.5.tgz#9ee4c51b267ac5ba8cdbf9bb9d4e8b74410d9669"
integrity sha512-RqKBqE10pb7zh0G/YiYVdX/MqenDYIgLGcaCqbszTAfW2SSLyp9EczsnmHtRgO1fO1OQq76+gaK7UdC1TEIGqQ==
"@sentry/cli-darwin@2.26.0":
version "2.26.0"
resolved "https://registry.yarnpkg.com/@sentry/cli-darwin/-/cli-darwin-2.26.0.tgz#6b44500dd549415c5f8b7228a3f4aef18a2e6766"
integrity sha512-SJ4ts9VELoLdOx1g034Tv2nGqhjutBYNAI3WMsjBaQG3tqNPJkQJKGrOqfpL6kTdO2tqQIAYeVw60yqWuHU3FA==

"@sentry/cli-linux-arm64@2.26.0":
version "2.26.0"
resolved "https://registry.yarnpkg.com/@sentry/cli-linux-arm64/-/cli-linux-arm64-2.26.0.tgz#dfe28a7caeffd8bd68476b709ba5f5f50fa74244"
integrity sha512-tAsK5pWrLyU+zqoW0uwylfLB7udOV8FtU8xqcfMsYGxt44zviiuxzKeDnaUdHsZcvk03aTAyf1Dxqn0u32A0MA==

"@sentry/cli-linux-arm@2.26.0":
version "2.26.0"
resolved "https://registry.yarnpkg.com/@sentry/cli-linux-arm/-/cli-linux-arm-2.26.0.tgz#cae4cf7db31a0cb4dba5243fce826abfa71dc404"
integrity sha512-qNqKLf3eGowhm+4gg47jGLfova5SLgC0wvWX181U+w94oVGp4onuSjbqpy7wbSA9nsfTXllMhEFI5jA4CMmZVw==

"@sentry/cli-linux-i686@2.26.0":
version "2.26.0"
resolved "https://registry.yarnpkg.com/@sentry/cli-linux-i686/-/cli-linux-i686-2.26.0.tgz#29cd6617d2e764dec4cff377ede58762b87e9a66"
integrity sha512-+dSFR9rK6o6F0gBxoU0mrHw18qVgF1t27Y0jvdItMtDuCuduBuXTffmsbBwbPFWBgWuLPG+ojB1LuoBt5qVMng==

"@sentry/cli-linux-x64@2.26.0":
version "2.26.0"
resolved "https://registry.yarnpkg.com/@sentry/cli-linux-x64/-/cli-linux-x64-2.26.0.tgz#a54dbcdd5c377ba97f7d3cc8115f25e68c3aded4"
integrity sha512-oY86ECWVQuk434K+enUVZnn28T8qxjJTpxN079xvz7SIWOxQ609tMva91Ywo0gExcu07AZ0pg71XFsEQ9WhZgA==

"@sentry/cli-win32-i686@2.26.0":
version "2.26.0"
resolved "https://registry.yarnpkg.com/@sentry/cli-win32-i686/-/cli-win32-i686-2.26.0.tgz#42fdf7006e9e420cb0b3e6b70d9f44f6807906e9"
integrity sha512-vLju9NFl4venKEVpuFJpxaCwa2NdG6C9mhYNqxRvZAPrXWMdMd697qBDOMepAPT7CI8EWiyXUwMli0WjGXGMeQ==

"@sentry/cli-win32-x64@2.26.0":
version "2.26.0"
resolved "https://registry.yarnpkg.com/@sentry/cli-win32-x64/-/cli-win32-x64-2.26.0.tgz#805cb184652d4a608128b70f9e19c1117f25c6f6"
integrity sha512-r3ZaxdHGC6OyJhOxO5ADzAitpGcgT/PkqQzOzKXBOebHj5jzwY27JWjdNhpT6sJZDII13HxqwISRedVWftZgRw==

"@sentry/cli@^2.21.2":
version "2.26.0"
resolved "https://registry.yarnpkg.com/@sentry/cli/-/cli-2.26.0.tgz#94cee60c89f457318540f74f8f1158357c2dd706"
integrity sha512-WRrY9nkjLLUvyo+l8KE0x0Q+0NtCd2U8HYJzh3kyJHyyfKWiSH7ZhExcsb2MoSIjlzbKjjrIJzxhklZABkidDw==
dependencies:
https-proxy-agent "^5.0.0"
node-fetch "^2.6.7"
progress "^2.0.3"
proxy-from-env "^1.1.0"
which "^2.0.2"
optionalDependencies:
"@sentry/cli-darwin" "2.26.0"
"@sentry/cli-linux-arm" "2.26.0"
"@sentry/cli-linux-arm64" "2.26.0"
"@sentry/cli-linux-i686" "2.26.0"
"@sentry/cli-linux-x64" "2.26.0"
"@sentry/cli-win32-i686" "2.26.0"
"@sentry/cli-win32-x64" "2.26.0"

"@sentry/core@7.81.1":
version "7.81.1"
Expand Down
6 changes: 6 additions & 0 deletions example/ionic-vue3/.browserslistrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Chrome >=79
ChromeAndroid >=79
Firefox >=70
Edge >=79
Safari >=14
iOS >=14
27 changes: 27 additions & 0 deletions example/ionic-vue3/.eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
.DS_Store
node_modules
/coverage
/dist
/ios
/android


# local env files
.env.local
.env.*.local

# Log files
npm-debug.log*
yarn-debug.log*
yarn-error.log*
pnpm-debug.log*

# Editor directories and files
.idea
.vscode
*.suo
*.ntvs*
*.njsproj
*.sln
*.sw?

20 changes: 20 additions & 0 deletions example/ionic-vue3/.eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
module.exports = {
root: true,
env: {
node: true
},
'extends': [
'plugin:vue/vue3-essential',
'eslint:recommended',
'@vue/typescript/recommended'
],
parserOptions: {
ecmaVersion: 2020
},
rules: {
'no-console': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
'no-debugger': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
'vue/no-deprecated-slot-attribute': 'off',
'@typescript-eslint/no-explicit-any': 'off',
}
}
32 changes: 32 additions & 0 deletions example/ionic-vue3/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Specifies intentionally untracked files to ignore when using Git
# http://git-scm.com/docs/gitignore

*~
*.sw[mnpcod]
.tmp
*.tmp
*.tmp.*
*.sublime-project
*.sublime-workspace
.DS_Store
Thumbs.db
UserInterfaceState.xcuserstate
$RECYCLE.BIN/

*.log
log.txt
npm-debug.log*

/.idea
/.ionic
/.sass-cache
/.sourcemaps
/.versions
/.vscode/*
!/.vscode/extensions.json
/coverage
/dist
/node_modules
/platforms
/plugins
/www
5 changes: 5 additions & 0 deletions example/ionic-vue3/.vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"recommendations": [
"ionic.ionic"
]
}
Loading
Loading