-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Vue projects weren't able to reference the VUE app. #559
Conversation
"@sentry/angular": "7.93.0", | ||
"@sentry/angular-ivy": "7.93.0", | ||
"@sentry/react": "7.93.0", | ||
"@sentry/vue": "7.93.0" | ||
"@sentry/angular": "7.81.1", | ||
"@sentry/angular-ivy": "7.81.1", | ||
"@sentry/react": "7.81.1", | ||
"@sentry/vue": "7.81.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the downgrade is intentional to as all the packages from the JS monorepo must match in version. Should we follow up with JS upgrade PR? Before the next capacitor release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather release a new version with only this change since it's blocking vue users from using it and on the next version, make the javascript bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you. 🚀
Instructions and example for changelogPlease add an entry to ## Unreleased
### Fixes/Features
- Vue projects weren't able to reference the VUE app ([#559](https://github.com/getsentry/sentry-capacitor/pull/559)) If none of the above apply, you can opt out of this check by adding |
This PR fixes the vue options reference so users are able to properly use Sentry Capacitor with VUE.
Also I added a VUE Sample for testing the build to avoid any regressions in the future.
And Fixed a bad reference to the HybridSdks.
Lastly, I made changes to the release integration because I found the following error
Fixes #554