Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Vue projects weren't able to reference the VUE app. #559

Merged
merged 6 commits into from
Jan 30, 2024

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Jan 29, 2024

This PR fixes the vue options reference so users are able to properly use Sentry Capacitor with VUE.
Also I added a VUE Sample for testing the build to avoid any regressions in the future.
And Fixed a bad reference to the HybridSdks.
Lastly, I made changes to the release integration because I found the following error

./node_modules/@sentry/capacitor/dist/esm/integrations/devicecontext.js:17:8-25 - Error: export 'addEventProcessor' (imported as 'addEventProcessor') was not found in '@sentry/core' (possible exports: BaseClient, DEFAULT_ENVIRONMENT, FunctionToString, Hub, IdleTransaction, InboundFilters, Integrations, LinkedErrors, ModuleMetadata, SDK_VERSION, Scope, ServerRuntimeClient, SessionFlusher, Span, SpanStatus, TRACING_DEFAULTS, Transaction, addBreadcrumb, addGlobalEventProcessor, addIntegration, addTracingExtensions, captureCheckIn, captureEvent, captureException, captureMessage, close, closeSession, configureScope, continueTrace, createCheckInEnvelope, createEventEnvelope, createTransport, ensureHubOnCarrier, extractTraceparentData, flush, getActiveSpan, getActiveTransaction, getCurrentHub, getDynamicSamplingContextFromClient, getEnvelopeEndpointWithUrlEncodedAuth, getHubFromCarrier, getIntegrationsToSetup, getMainCarrier, getReportDialogEndpoint, hasTracingEnabled, initAndBind, isSentryRequestUrl, lastEventId, makeMain, makeMultiplexedTransport, makeOfflineTransport, makeSession, prepareEvent, runWithAsyncContext, setAsyncContextStrategy, setContext, setExtra, setExtras, setHubOnCarrier, setMeasurement, setTag, setTags, setUser, spanStatusfromHttpCode, startActiveSpan, startIdleTransaction, startInactiveSpan, startSpan, startSpanManual, startTransaction, trace, updateSession, withMonitor, withScope)

Fixes #554

Comment on lines -43 to +47
"@sentry/angular": "7.93.0",
"@sentry/angular-ivy": "7.93.0",
"@sentry/react": "7.93.0",
"@sentry/vue": "7.93.0"
"@sentry/angular": "7.81.1",
"@sentry/angular-ivy": "7.81.1",
"@sentry/react": "7.81.1",
"@sentry/vue": "7.81.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the downgrade is intentional to as all the packages from the JS monorepo must match in version. Should we follow up with JS upgrade PR? Before the next capacitor release?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather release a new version with only this change since it's blocking vue users from using it and on the next version, make the javascript bump.

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you. 🚀

@lucas-zimerman lucas-zimerman merged commit f3ddea3 into main Jan 30, 2024
8 checks passed
@lucas-zimerman lucas-zimerman deleted the fix/vue-ref branch January 30, 2024 16:35
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.
Example:

## Unreleased

### Fixes/Features

- Vue projects weren't able to reference the VUE  app ([#559](https://github.com/getsentry/sentry-capacitor/pull/559))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 8740f9b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue not properly supported
2 participants