Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AGP to 7.3.0, java to 11, kotlin to 1.6.10 #378

Merged
merged 7 commits into from
Sep 30, 2022
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Sep 26, 2022

📜 Description

  • Bumps current AGP version to 7.3.0
  • Bumps preview AGP versions to 7.4.0-beta01 and 8.0.0-alpha01
  • Bumps kotlin to 1.6.10, languageVersion to 1.4 (1.4 is supported from Gradle 7.0+, which is what our plugin supports anyway)
  • Bumps Java to 11 (our plugin supports only AGP 7.0+, which, in turn, supports java 11+)
  • Bumps compileSdkVersion to 33 on samples (tested manually, no problems)
  • Switch from AndroidManifest package name to namespace attribute in gradle dsl

💡 Motivation and Context

Closes #373 #364 #274

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@romtsn romtsn requested a review from adinauer as a code owner September 26, 2022 22:04
@romtsn romtsn requested a review from marandaneto September 26, 2022 22:06
@marandaneto
Copy link
Contributor

@romtsn you can likely close #274 as well

@romtsn
Copy link
Member Author

romtsn commented Sep 28, 2022

@marandaneto oh yeah, thanks for pointing out

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; one question regarding gradle version

@romtsn romtsn merged commit 4f91cb5 into main Sep 30, 2022
@romtsn romtsn deleted the chore/version-updates branch September 30, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update example to target Android 13
3 participants