Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Java 11 and Kotlin 1.4 #274

Closed
marandaneto opened this issue Feb 4, 2022 · 5 comments
Closed

Use Java 11 and Kotlin 1.4 #274

marandaneto opened this issue Feb 4, 2022 · 5 comments

Comments

@marandaneto
Copy link
Contributor

marandaneto commented Feb 4, 2022

'compileJava' task (current target is 11) and 'compileKotlin' task (current target is 1.8) jvm target compatibility should be set to the same Java version.

Since we support AGP 7.x+ https://developer.android.com/studio/releases/gradle-plugin#jdk-11
We can use Java 11 features and no need to add compat. to VERSION_1_8.
Same for Kotlin 1.5, No need to languageVersion = "1.3"
https://developer.android.com/studio/releases/gradle-plugin#incompatibility_with_14x_kotlin_multiplatform_plugin

@romtsn
Copy link
Member

romtsn commented Feb 4, 2022

Should be done for 3.0 GA probably? just to make sure, even if it's breaking :)

@marandaneto
Copy link
Contributor Author

Yes if possible, it's not breaking tho, since AGP 7.x requires Java 11, so requiring AGP 7.x is already the breaking change by itself.

@marandaneto
Copy link
Contributor Author

Bumping to Java 11 lead me to this issue https://youtrack.jetbrains.com/issue/KT-48745

@cortinico
Copy link
Contributor

Bumping to Java 11 lead me to this issue youtrack.jetbrains.com/issue/KT-48745

That is just a warning though, no?

@marandaneto
Copy link
Contributor Author

Yes, but since there are many ways of setting source/target compatibility, plus language version compatibility on Kotlin etc, I was unsure of the correct way since the Warning was never gone, not a high priority for now, when Bumping to Kotlin 1.6, the warning should be gone anyways.

@romtsn romtsn moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Mar 9, 2022
@romtsn romtsn closed this as completed Sep 30, 2022
Repository owner moved this from Backlog to Done in Mobile & Cross Platform SDK Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants