-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Temporary fix for interactive prompt on createuser #1370
Conversation
Fixes #1341 temporarily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
I'm not gonna bother you why this worked on v2.0.1
:)
Very likely because of the earlier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
COMPOSE_PROJECT_NAME
is not working.
If you want to, we can remove it from this PR and re-open #1367 for that.
It is working: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! I saw this:
Successfully tagged sentry-cleanup-self-hosted-local:latest
and I was mistaken that images created should have -0-
too.
It is working indeed: https://github.com/getsentry/self-hosted/runs/5494674968?check_suite_focus=true#step:4:1853
Ok but why does it work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this works but it seems to work and doesn't look that bad.
This works because I feed a So instead of waiting for input indefinitely, it just moves along. The real fix is making the code I mentioned over #1341 (comment) not ask for a prompt when |
Fixes #1341 temporarily.