Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cloudbuild.yaml for GCB #1315

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Add a cloudbuild.yaml for GCB #1315

merged 1 commit into from
Feb 10, 2022

Conversation

chadwhitacre
Copy link
Member

Closes #1311.

@chadwhitacre
Copy link
Member Author

GCB is green, slogging through #1171 #1293 #1294 ...

@BYK
Copy link
Member

BYK commented Feb 9, 2022

Why not go the other way around and replace those GCB runs with GitHub Actions? You can now use OIDC for securely pushing images to Google Cloud: https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-google-cloud-platform

Would be less maintenance and better DX as we all know nobody looks at (or understands) GCB logs 😀

Copy link
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I have understood correctly, this would happen in a private environment where non-employed contributors without access cannot see the logs over there or even if it had been broken or not, but if this helps sentry guys, sure, why not?

@chadwhitacre
Copy link
Member Author

Gosh, with 2x the CI builds post-#1290 it's even harder to get a clean build. :-/

@chadwhitacre
Copy link
Member Author

Why not go the other way around and replace those GCB runs with GitHub Actions?

That's not a bad idea, not sure I want to set the plow that deep though since it involves getting buy-in from other teams and this is an action item for a CI incident, I'd like to resolve sooner than later to prevent future bugs from taking down CI.

@chadwhitacre
Copy link
Member Author

If I have understood correctly, this would happen in a private environment where non-employed contributors without access cannot see the logs over there or even if it had been broken or not, but if this helps sentry guys, sure, why not?

I think there may actually be a loophole where direct links to raw GCB output is available with no authentication. Generally the GCB build should be green if the rest are, of course until we once again hit something like this is designed to catch in the first place. Hopefully rare though.

I like @BYK's suggestion as a way to make this more open, but again I think that is a future improvement.

@BYK
Copy link
Member

BYK commented Feb 9, 2022

Happy to give you a hand as the GCB config for Sentry itself is already public (along with Snuba and Relay). All I'd need from your end would be setting up OIDC which should be a breeze.

@chadwhitacre chadwhitacre merged commit 5c52017 into master Feb 10, 2022
@chadwhitacre chadwhitacre deleted the cwlw/gcbrun branch February 10, 2022 14:08
@chadwhitacre
Copy link
Member Author

Thanks @BYK. Merging this for now. I don't have bandwidth to drive GCB→GHA right now but if you start making PRs I will try to keep up. 😁

@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build on GCB during CI
3 participants