Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI compose version 1.29.2 / 2.0.1 / 2.2.3 #1290

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

chadwhitacre
Copy link
Member

@chadwhitacre chadwhitacre commented Feb 2, 2022

Redo of #1251 after #1272.

@chadwhitacre
Copy link
Member Author

This and #1289 are pointed in basically the same direction, over there there is more refactoring but no addition of additional Compose versions to the CI matrix. I think if this is green we merge this first to keep close to the original plan with #1251, and then rebase over there to pick up the refactor as well.

@aminvakil
Copy link
Collaborator

Failed CI, seems to be related to docker/compose#6704.

Closing and reopening to try again.

@aminvakil aminvakil closed this Feb 3, 2022
@aminvakil aminvakil reopened this Feb 3, 2022
@chadwhitacre
Copy link
Member Author

Blorg, I'm reluctant to merge with flakey CI, since this impacted sentry CI last time around. 🤔

What is it about docker/compose#6704 that is biting us?

@chadwhitacre
Copy link
Member Author

Flakiness reticketed as #1294. Merging ...

@chadwhitacre chadwhitacre disabled auto-merge February 3, 2022 20:48
@chadwhitacre chadwhitacre merged commit e3f5670 into master Feb 3, 2022
@chadwhitacre chadwhitacre deleted the cwlw/revert-revert branch February 3, 2022 20:49
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants