Take some actions to avoid unhealthy containers #1241
Conversation
|
Are we sure changing all healthcheck timeouts for all users to 60s is a good idea? My question is are there any situations in self-hosted where if something does not respond in 5 seconds, it's broken? |
install.sh
Outdated
| source parse-cli.sh | ||
| source dc-detect-version.sh | ||
| source turn-things-off.sh |
There was a problem hiding this comment.
error-handling should come as early as possible?
There was a problem hiding this comment.
Fair point. It depends on $dc so moving just after that in c48efe0.
There was a problem hiding this comment.
Hmm ... thought through this a little further and created 2b9a179. Eh?
If it's broken after 5s it will still be broken after 60s, right? |
Well if something is wrong and it responds in 30s or so, it's broken in my POV. |
Like I said in #1178 (comment) best if it could be set in |
Okay, let's run with this for a while and if we find that it's causing problems in the other direction we can look at making it configurable, would rather not introduce additional complexity if we don't have to. |
|
@aminvakil I mean, if "someone else" wants to make a PR for configurability ... ;) |
|
Pretty sure we're good here, merging. |
Closes #1178