Organize install.sh a bit

install.sh

@@ -1,20 +1,23 @@
 #!/usr/bin/env bash
 set -e
+
+# Pre-pre-flight? 🤷
 if [[ -n "$MSYSTEM" ]]; then
   echo "Seems like you are using an MSYS2-based system (such as Git Bash) which is not supported. Please use WSL instead.";
   exit 1
 fi
 
-umask 002
-
 source "$(dirname $0)/install/_lib.sh"  # does a `cd .../install/`, among other things
 
+# Pre-flight. No impact yet.
 source parse-cli.sh
 source dc-detect-version.sh
 source error-handling.sh
-source turn-things-off.sh
 source check-latest-commit.sh
 source check-minimum-requirements.sh
+
+# Let's go! Start impacting things.
+source turn-things-off.sh
 source create-docker-volumes.sh
 source ensure-files-from-examples.sh
 source generate-secret-key.sh

install/_lib.sh

@@ -1,6 +1,9 @@
 set -euo pipefail
 test "${DEBUG:-}" && set -x
 
+# Override any user-supplied umask that could cause problems, see #1222
+umask 002
+
 # Thanks to https://unix.stackexchange.com/a/145654/108960
 log_file="sentry_install_log-`date +'%Y-%m-%d_%H-%M-%S'`.txt"
 exec &> >(tee -a "$log_file")