Use set in fetch_columns for efficient #5336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rauchy @arikfr @gabrieldutra @kravets-levko PTAL, thanks |
1 task
Change list to set
69be424 to
ff02026
Compare
|
PTAL this pr if you have time @justinclift @konnectr @junnplus , just a simple improvement |
|
backend lint failed due to #6321 |
Codecov Report
@@ Coverage Diff @@
## master #5336 +/- ##
=======================================
Coverage 60.75% 60.75%
=======================================
Files 153 153
Lines 12511 12511
Branches 1694 1694
=======================================
Hits 7601 7601
Misses 4684 4684
Partials 226 226
|
konnectr
approved these changes
Jul 31, 2023
|
Merged! Thanks heaps for creating this PR @zhongjiajie, and for keeping with it through all of this extra time. 😄 |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
Change list to set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list to set
What type of PR is this? (check all applicable)
Description
Use set replace list more efficient, cause function
fetch_columnscall frequently,O(1)is better thanO(n)Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)