fix flake8 (#6321)

.github/workflows/ci.yml

@@ -16,7 +16,7 @@ jobs:
       - uses: actions/setup-python@v4
         with:
           python-version: '3.8'
-      - run: sudo pip install flake8 black isort
+      - run: sudo pip install flake8==6.1.0 black==23.1.0 isort==5.12.0
       - run: flake8 .
       - run: black --check .
       - run: isort --check-only --diff .

.pre-commit-config.yaml

@@ -8,3 +8,8 @@ repos:
     hooks:
       - id: black
         language_version: python3
+  - repo: https://github.com/pycqa/flake8
+    rev: 6.1.0
+    hooks:
+      - id: flake8
+

redash/query_runner/__init__.py

@@ -278,7 +278,7 @@ def _get_tables(self, schema_dict):
 
     def _get_tables_stats(self, tables_dict):
         for t in tables_dict.keys():
-            if type(tables_dict[t]) == dict:
+            if isinstance(tables_dict[t], dict):
                 res = self._run_query_internal("select count(*) as cnt from %s" % t)
                 tables_dict[t]["size"] = res[0]["cnt"]
 

redash/query_runner/python.py

@@ -213,7 +213,7 @@ def execute_query(data_source_name_or_id, query, result_type=None):
         :query string: Query to run
         """
         try:
-            if type(data_source_name_or_id) == int:
+            if isinstance(data_source_name_or_id, int):
                 data_source = models.DataSource.get_by_id(data_source_name_or_id)
             else:
                 data_source = models.DataSource.get_by_name(data_source_name_or_id)
@@ -241,7 +241,7 @@ def get_source_schema(data_source_name_or_id):
         :return:
         """
         try:
-            if type(data_source_name_or_id) == int:
+            if isinstance(data_source_name_or_id, int):
                 data_source = models.DataSource.get_by_id(data_source_name_or_id)
             else:
                 data_source = models.DataSource.get_by_name(data_source_name_or_id)