Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move odata loading message and spinner styles to the right place #986

Merged
merged 1 commit into from
May 1, 2024

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented May 1, 2024

Closes getodk/central#603 and closes getodk/central#526

CSS to style the spinner and message text for the OdataLoadingMessage component is now in the right place. This shows up on the Entities page and Submissions page.

Screenshot 2024-05-01 at 11 09 16 AM Screenshot 2024-05-01 at 11 17 34 AM

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to user documentation? If so, please file an issue here and include the link below.

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@ktuite ktuite requested a review from matthew-white May 1, 2024 18:19
@ktuite ktuite merged commit bd2581a into master May 1, 2024
1 check passed
@ktuite ktuite deleted the ktuite/odata_css branch May 1, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spinner is misplaced in OData loading message Style loading message for OData table
2 participants