Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner is misplaced in OData loading message #603

Closed
matthew-white opened this issue Mar 8, 2024 · 0 comments · Fixed by getodk/central-frontend#986
Closed

Spinner is misplaced in OData loading message #603

matthew-white opened this issue Mar 8, 2024 · 0 comments · Fixed by getodk/central-frontend#986
Assignees
Labels
bug frontend Requires a change to the UI styles Changes to CSS

Comments

@matthew-white
Copy link
Member

The OData loading message shows text and a spinner. The two are supposed to be next to each other, but right now they aren't:

I noticed this on the entity Data page, but I'm pretty sure it's an issue on the Submissions page as well.

I think the issue is that the following styles have become orphaned and need to be moved into the OdataLoadingMessage component. There are other styles there in addition to the placement of the spinner, e.g., the text color. https://github.com/getodk/central-frontend/blob/b69839d92ef3343d943eaa5ced9888839c5b7d0e/src/components/submission/list.vue#L377-L394

@matthew-white matthew-white added bug frontend Requires a change to the UI labels Mar 8, 2024
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Mar 8, 2024
@matthew-white matthew-white added the styles Changes to CSS label Apr 30, 2024
@ktuite ktuite moved this from 🕒 backlog to ✏️ in progress in ODK Central May 1, 2024
@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug frontend Requires a change to the UI styles Changes to CSS
Projects
Status: ✅ done
Development

Successfully merging a pull request may close this issue.

2 participants