Merge pull request mapfish#492 from tsauerwein/http-cache-error

Log errors if request fails in http cache

core/src/main/java/org/mapfish/print/http/HttpRequestCache.java

@@ -139,15 +139,19 @@ public ClientHttpResponse execute() throws IOException {
         public Void call() throws Exception {
             final String baseMetricName = HttpRequestCache.class.getName() + ".read." + getURI().getHost();
             final Timer.Context timerDownload = HttpRequestCache.this.registry.timer(baseMetricName).time();
-            ClientHttpResponse originalResponse = this.originalRequest.execute();
+            ClientHttpResponse originalResponse = null;
             try {
+                originalResponse = this.originalRequest.execute();
                 LOGGER.debug("Caching URI resource " + this.originalRequest.getURI());
                 this.response = new CachedClientHttpResponse(originalResponse);
             } catch (IOException e) {
+                LOGGER.error("Request failed " + this.originalRequest.getURI(), e);
                 HttpRequestCache.this.registry.counter(baseMetricName + ".error").inc();
                 throw e;
             } finally {
-                originalResponse.close();
+                if (originalResponse != null) {
+                    originalResponse.close();
+                }
                 timerDownload.stop();
             }
             return null;

core/src/main/java/org/mapfish/print/http/MfClientHttpRequestFactoryImpl.java

@@ -153,6 +153,8 @@ protected Response executeInternal(@Nonnull final HttpHeaders headers) throws IO
                 }
             }
             HttpResponse response = this.client.execute(this.request, this.context);
+            LOGGER.debug("Response: " + response.getStatusLine().getStatusCode() + " -- " + this.getURI());
+
             return new Response(response);
         }
     }