Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log errors if request fails in http cache #492

Merged
merged 1 commit into from
Feb 7, 2017

Conversation

tsauerwein
Copy link

Closes #491

@sbrunner
Copy link
Member

@tsauerwein When we to an HTTP request who it failed, is it cached?
For me it shouldn't...

@tsauerwein
Copy link
Author

Responses for requests with a status code other than 200 are also cached. The users of the cache (e.g. layers) can decide what they do in such a case. But that is not the point of this PR.

@sbrunner
Copy link
Member

But that is not the point of this PR.

Not directly but it's good to understand the context :-)

The users of the cache (e.g. layers) can decide what they do in such a case.

I try to find some more informations here: http://mapfish.github.io/mapfish-print-doc/layers.html without any success... How is it working?

@tsauerwein
Copy link
Author

The users of the cache (e.g. layers) can decide what they do in such a case.

I try to find some more informations here: http://mapfish.github.io/mapfish-print-doc/layers.html without any success... How is it working?

By "users of the cache" I mean the layer classes which get the request responses from the cache and decide for example if a pink image is rendered or the print fails. Users of MFP can configure this behavior with failOnError, see http://mapfish.github.io/mapfish-print-doc/layers.html

@tsauerwein
Copy link
Author

Merging because no functional change, this PR is only adding logging statements.
@sbrunner, if you want to change the behavior of the error handling, I'd propose to do this in a new PR.

@tsauerwein tsauerwein merged commit 35fb61b into mapfish:master Feb 7, 2017
@tsauerwein tsauerwein deleted the http-cache-error branch February 7, 2017 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors when doing requests in HttpRequestCache are not logged
2 participants