#9180: Attribute Table in read only mode

[dsuren1]

Description

This PR adds a feature to layer setting to disable editing in Attribute table

Please check if the PR fulfills these requirements

• The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

• Feature

Issue

What is the current behavior?

• Attribute Table in read only mode #9180

What is the new behavior?

• The option is un-ticket by default
• The enabling it will disable editing in Attribute table
• The attribute edit icon is hidden in Identify panel for the selected layer
• The options is saved along with layer setting

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

• Yes, and I documented them in migration notes
• No

Other useful information

#7285 (comment)

[offtherailz]

• change the flag readOnlyAttribute to disableFeaturesEditing

• having a selector(Creator) that relies on a type of a plugin passed to get the proper layer rises the complxity of the solution without helping too much on future maintainence.

I suggest to refactor this solution by:

• keeping isEditingAllowedSelector untouched, without transforming it in a selector creator. This selector tells only if the editor is enabled in general.
• remove readOnlyAttributeSelector that is hard to maintain (it relies on two plugins state)
• Whenever a button that open the feature editor is present, add the additional check to hide it :
  • you can add an additional utility function like areFeaturesEditable that checks the particular flag and supportsFeatureEditing that checks the type.

// utils
const supportedEditLayerTypes = [ "wms", "wfs"];
function supportsFeatureEditing(layer) {return includes(supportedEditLayerTypes, layer.type) };
function areLayerFeaturesEditable(layer) =>  !layer?.disableFeaturesEditing && supportsFeatureEditing(layer);}

For instance in IdentifyContainer:

showEdit: showEdit && areLayerFeaturesEditable(layer) && isEditingAllowed && !!targetResponse && responseValidForEdit(targetResponse),

(and similar in feature grid toolbar).

This reduces a lot:

• the code to use
• the tests
• the maintainance
• the complexity

Please let me know what you think.

[dsuren1]

I agree. I initially thought of adding funcs as suggested but later thought it would be easier to manage in one place by a selector.

Anyway, I will make the necessary modification. Thanks!

[dsuren1]

Coveralls failing

[offtherailz]

trying to re-run

[offtherailz]

The selector is not needed anymore. Applying remove

[offtherailz]

When merged (it should auto-merge if coveralls responds), please @ElenaGalltest this on DEV. Thank you 🚀

[offtherailz]

@ElenaGallo, could you please test this on DEV ? Thank you