Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FeatureEditor] Allow to provide editable layers list #7285

Closed
jusabatier opened this issue Sep 8, 2021 · 9 comments
Closed

[FeatureEditor] Allow to provide editable layers list #7285

jusabatier opened this issue Sep 8, 2021 · 9 comments
Assignees
Milestone

Comments

@jusabatier
Copy link

Description

Actually, when FeatureEditor is activated, it's for all context's layers.
It would be great to have an option like "editingAllowedLayers" listing layers that we want to enable edition for.
For example in a context some layers can just be there for information, not edition.
This feature allow them to not look like they can be edited.

Acceptance criteria

  • Allow to parameter layers in a context for which we want to enable feature edition tools. (not all)
@jusabatier jusabatier added the New Feature used for new functionalities label Sep 8, 2021
@deepseainside75
Copy link

deepseainside75 commented Sep 27, 2021

That would be a great feature for us as well.
It would be an enabler for a lot of derived features from UI/UX perspective too!

@jusabatier
Copy link
Author

@tdipisa answers :

The context editor (who has write permission on the context) can control that option from layers settings of layers added in the context (step #2 of the wizard). The map editor (who has write permission on a map) can do the same at map level. If enabled, the Attribute Table (if present) will not appear in the toolbar when the layer is selected in TOC.

I didn't found such option that allow to set if a layer is available or not in edition.

@tdipisa
Copy link
Member

tdipisa commented Dec 15, 2022

@jusabatier

I didn't found such option that allow to set if a layer is available or not in edition.

This need to be implemented indeed.

@tdipisa
Copy link
Member

tdipisa commented Jan 31, 2023

As agreed in the call today and also already specified above we will provide this in a way that only admins or who has edit permission of the map/context can control it in layer settings.

@landryb
Copy link
Collaborator

landryb commented Feb 10, 2023

If enabled, the Attribute Table (if present) will not appear in the toolbar when the layer is selected in TOC.

@tdipisa i suppose you meant "the edit button in the attribute table will not appear" right ? we still want users not allowed to edit the data in a given layer to be able to see its attribute table..

@tdipisa
Copy link
Member

tdipisa commented Feb 10, 2023

yes @landryb let me reformulate in the right way. I'm sorry.

The context editor (who has write permission on the context) can control that option from layers settings of layers added in the context (step 2 of the wizard). The map editor (who has write permission on a map) can do the same at map level. If enabled and the Attribute Table is present, the edit button will not appear in the toolbar.

@dsuren1
Copy link
Contributor

dsuren1 commented May 16, 2023

@tdipisa @offtherailz

Possible approaches

Kindly let me know which design to proceed with. Your thoughts @tdipisa

Option 1
To have layer option under Display to enable/disable the layer for edit in Attribute table
Screenshot 2023-05-16 at 2 20 06 PM

Option 2
To have a toolbar option under Fields
Screenshot 2023-05-16 at 2 20 06 PM

@tdipisa
Copy link
Member

tdipisa commented May 16, 2023

@dsuren1 I would opt for Option 1 but it should stay in General and not in Display tab. I'm not convinced about Option 2 since this should be a general option to disable the layer editing while the Fields panel id dedicated to configure the aliases.
As far as the name of the option is concerned, it could be: Disable editing with Attribute Table or something like that.

@tdipisa
Copy link
Member

tdipisa commented May 17, 2023

Closed in favor of #9180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants