Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5972 fix npm install and remove checkcesium #5835

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Sep 4, 2020

Description

This pr fixes the npm script for project that was running the post install script due to the fact that mapstore is considered a library atm for projects

it also fixes a build problem in project with "html-to-draftjs": "1.5.0",

and it removes the check cesium script since is no longer needed

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#5792

What is the new behavior?

Now mapstore and newly created project have no longer the error

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

for a new created project i tested

  • npm install from scratch with no error
  • the whole process from creation to build the final war with no error
  • that cesium is still working by opening a the 3d viewer

for mapstore

  • npm install from scratch with no error
  • the whole process from creation to build the final war with no error

@MV88 MV88 added bug BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Sep 4, 2020
@MV88 MV88 added this to the 2020.02.01 milestone Sep 4, 2020
@MV88 MV88 self-assigned this Sep 4, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 83.533% when pulling 6b502b8 on MV88:5792_npm_install_prj into 5663c6e on geosolutions-it:master.

@tdipisa
Copy link
Member

tdipisa commented Sep 8, 2020

@MV88 can you please backport this to 2020.02.01?

@MV88 MV88 merged commit c1894d8 into geosolutions-it:master Sep 8, 2020
MV88 added a commit to MV88/MapStore2 that referenced this pull request Sep 8, 2020
…ions-it#5835)

* geosolutions-it#5972 fix npm install and remove checkcesium

* remove check cesium add html-to-draftjs
MV88 added a commit that referenced this pull request Sep 8, 2020
* #5972 fix npm install and remove checkcesium

* remove check cesium add html-to-draftjs
@MV88 MV88 removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants