#5292: Fixed opacity issues in printing #5972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f8aa333 to
492522c
Compare
mbarto
suggested changes
Oct 5, 2020
web/client/utils/PrintUtils.js
Outdated
| @@ -243,7 +243,7 @@ const PrintUtils = { | |||
| wms: { | |||
| map: (layer, spec) => ({ | |||
| "baseURL": PrintUtils.normalizeUrl(layer.url) + '?', | |||
| "opacity": layer.opacity || 1.0, | |||
| "opacity": layer.opacity || (layer.opacity === 0 ? 0 : 1.0), | |||
There was a problem hiding this comment.
Maybe we can extract a function for this repeated check?
mbarto
approved these changes
Oct 6, 2020
|
@offtherailz can you please backport this to 2020.02.xx? Thank you. |
offtherailz
added a commit
to offtherailz/MapStore2
that referenced
this pull request
Oct 6, 2020
…it#5972) * geosolutions-it#5292: Fixed opacity issues in printing * Unified opacity exract system in printutils
tdipisa
pushed a commit
that referenced
this pull request
Oct 6, 2020
mbarto
pushed a commit
to mbarto/MapStore2
that referenced
this pull request
Oct 9, 2020
…ions-it#5835) (geosolutions-it#5847) * geosolutions-it#5972 fix npm install and remove checkcesium * remove check cesium add html-to-draftjs
mricca
pushed a commit
to mricca/MapStore2
that referenced
this pull request
Oct 9, 2020
…ions-it#5835) * geosolutions-it#5972 fix npm install and remove checkcesium * remove check cesium add html-to-draftjs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes this issue: #5292 (comment)
Moreover fixes other minor issues found in WMS/OSM/Vector layers and printing (opacity = 0 becomes 1).
Added unit tests for all the use cases about opacity
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#5292
What is the new behavior?
Now the opacity is correct for every layer
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information