Uniformation of Edit Properties and detail card #5772
Comments
@offtherailz you want first for this task to be done, merged to master and then merge master to #5396 and continue work on #5396? |
* Adopt general SaveModal to MapGrid * added translations * post review rework * removed commented out code * added tests
|
@vlt1 here are some notes after testing:
How to Reproduce
Current Result Uder usefull information
|
|
@ElenaGallo I linked to this issue also the #5861 that introduces changes to the detail card. Please test them together with the issues you notified, because Updating a map description after adding a detail causes an issue seems to be solved, didn't tested the second point. |
|
The following problem are present on console:
Problem 1: The console gives the following error:
Problem 2: The console gives the following error:
Problem 3: The console gives the following errors:
Problem 4: The console gives the following errors:
Problem 5: The console gives the following errors:
|
|
@offtherailz the image plugin included in the text editor within this issue needs to be reviewed. Let's talk about that. |
|
@ElenaGallo These are not errors really, just failed requests. There is, for example, logic in mapstore to check if there is data accessible of the attribute in order to determine whether to create a new one or update the old one. So these errors are not indicative of anything wrong. |
|
@vlt1 yes, i know. They are just failed requests, but should be removed if possible. |
|
@vlt1 I agree with @ElenaGallo about this. There shouldn't be failing request if possible. @offtherailz @vlt1 are the performing of these failing requests needed? I've some concern on this to be honest. |
|
About the details request, I see that detail card is always persisted, empty, on the first re-save. I looked at it and the other errors are "correct" with the current workflow. When try to save thumbnail or details, it checks first if the attribute exists, in order to guess if you have to replace the existing linked resource or create a new one. Anyway, I think we could easely prevent this request error by doing a request to the whole resource attributes list of the map instead of the single value. |
|
@offtherailz well there is getResourceAttributes request that gets the attribute list, so if it doesn't fail then yes that should work |
Description
Now the Edit Properties tool (from home page) and the Save tools (From map/dashboard and stories) use 2 different implementations:
We need to reuse the generic component also for the Map/FeaturedMaps. This means that:
Acceptance Criteria
What kind of improvement you want to add? (check one with "x", remove the others)
Note for Developer
The ResourceModal support auto save of linkedResources and attributes, so please keep the same self-contained approch applying your changes, adding a fragment and reusing the same implicit save system you find for other attributes, linked resources (thumbnail) and permissions. At the end, remove all the logic that is not used anymore.
After this task has been done, the pull request Responsive Design - Info Box #5396 can continue, so the entry point for the administrator for the detail card is the Save / Save as tool.
The origina 'epic' for this task was Related resources saving flow issues due to permission updates - Reuse dashboard code #2908, but it's old, so some information can not be true anymore, I add it just as reference.
Notes for testers
Many issues was related to the tool that is going to be replaced with an existing one. So after this issue is closed, you can (and also developer should check) see that the following issues has been solved.
Now I'm closing them in favour of this one.
#3096 _Steps to reproduce_
Create a new map, with a thumbnail and detail card
Edit the map you created removing the thumbnail, then save again
Edit again the map and try to edit detail
Try to Save
Expected Result
The map is saved again with changes to the detail card
Current Result
Click on save button has no effect. You have to edit also title or description to make it work.
#3406
This should have been solved by fixing the problem in NODATA handling (#5760) plus this fix.
Steps to reproduce
MAPS
Login as admin
Create new map
Save writing only the name
Go back to homepage
From homepage, set a thumbnail, some detials and the permission Testers can edit
Logout from admin and login as tester
Open edit properties from homepage
Problem 1: Can't see the details (NO_DETAILS_AVAILABLE) and can't edit them
Problem 2: If I set a new thumbnail, the prevous one is not deleted (DELETE 403 forbidden)
DASHBOARDS AND STORIES
Login as admin
Create new dashboard/story
Save writing only the name
Go back to homepage
From homepage, set a thumbnail
Problem 1: The console gives the following error: GET .../thumbnail 404 (Not Found)
Login as admin
Create new dashboard/story
Save writing only the name
Go back to homepage
From homepage, set the permission Testers can edit
Logout from admin and login as tester
Open edit properties from homepage
Problem 2: Tryng to set a thumbnail in console: GET .../thumbnail 404 Not Found
- #4440 Improvement: allow editing detail card from Map viewer.
#4443
Steps to reproduce
Expected Result
The details are visible in the window
Current Result
The details windows shows the error: No_details_available
The text was updated successfully, but these errors were encountered: