Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] csw harvester encountering an empty page has to continue harvesting #3713

Closed
wants to merge 1 commit into from
Closed

[WIP] csw harvester encountering an empty page has to continue harvesting #3713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions harvesters/src/main/java/org/fao/geonet/kernel/harvest/harvester/csw/Harvester.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,13 +389,6 @@ private void searchAndAlign(CswServer server, Search s, Set<String> uuids,
break;
}

// Another way to escape from an infinite loop

if (returnedCount == 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check was introduced as a workaround to #1429. Would the harvester still work for a server not returning nextRecord?

log.warning("Forcing harvest end since numberOfRecordsReturned = 0");
break;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also change

start = nextRecord;

line 401.

@josegar74 any opinion?

Copy link
Contributor

@juanluisrp juanluisrp Feb 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing something like

if (nextRecord !=null && nextRecord < start) {
        log.warning(String.format("Forcing harvest end since nextRecord < start (nextRecord = %d, start = %d", nextRecord, start));
        break;
}

// Start position of next record.
// Note that some servers may return less records than requested (it's ok for CSW protocol)
start += returnedCount;
Expand Down