[WIP] csw harvester encountering an empty page has to continue harvesting #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
condition on next record not changing should suffice avoiding infinite loop. furthermore, empty page condition induce an random behaviour, harvesting will stop on a fully empty page, incomplete page are accepted, this depending on page size and records order.
fxprunayre
reviewed
Jun 17, 2019
| log.warning("Forcing harvest end since numberOfRecordsReturned = 0"); | ||
| break; | ||
| } | ||
|
|
There was a problem hiding this comment.
There was a problem hiding this comment.
I'm missing something like
if (nextRecord !=null && nextRecord < start) {
log.warning(String.format("Forcing harvest end since nextRecord < start (nextRecord = %d, start = %d", nextRecord, start));
break;
}
juanluisrp
reviewed
Feb 11, 2020
| @@ -389,13 +389,6 @@ private void searchAndAlign(CswServer server, Search s, Set<String> uuids, | |||
| break; | |||
| } | |||
|
|
|||
| // Another way to escape from an infinite loop | |||
|
|
|||
| if (returnedCount == 0) { | |||
There was a problem hiding this comment.
This check was introduced as a workaround to #1429. Would the harvester still work for a server not returning nextRecord?
juanluisrp
added a commit
to juanluisrp/core-geonetwork
that referenced
this pull request
Feb 12, 2020
Some server aren't compliant with CSW specification. In some cases they can return a value different of 0 for nextRecord when the harvester has reached the end of the available results. This commit stops the harvesting loop if the value of `nextResult` returned by the server is smaller than the current `start` record. Could be a complement to geonetwork#3713.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
condition on next record not changing should suffice avoiding infinite
loop. furthermore, empty page condition induce an random behaviour,
harvesting will stop on a fully empty page, incomplete page are accepted,
this depending on page size and records order.