Update dependencies with test fixes #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dependencies with test fixes
Closed
| @@ -46,8 +46,8 @@ module.exports = function(grunt) { | |||
| file: 'test/fixtures/_component.json', | |||
| changelog: 'test/fixtures/_CHANGELOG.md', | |||
| additionalFiles: ['test/fixtures/_bower.json'], | |||
| changelogText: '### <%= version %>\n', | |||
| commitMessage: 'v<%= version %>' | |||
| changelogText: grunt.template.process('### <%= version %>\n', {data: {'version': '0.0.13'}}), | |||
There was a problem hiding this comment.
This will cause a problem as it adds a requirement that we update the Gruntfile every time we update the version
There was a problem hiding this comment.
Why? In the /test/fixtures/component.json file the version will be always 0.0.12.
There was a problem hiding this comment.
hmm maybe your right, going to look back in history at the tests...
|
@drublic I believe the change is safe, any opinion? |
|
Any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I updated the dependecies and fixed the failed tests.
💻