Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update all dependencies #151

Closed
wants to merge 4 commits into from
Closed

update all dependencies #151

wants to merge 4 commits into from

Conversation

marcobiedermann
Copy link

Update dependencies

@drublic
Copy link
Collaborator

drublic commented Apr 18, 2016

@marcobiedermann Can you please look at this again? Checks failed.

@dorgan
Copy link
Collaborator

dorgan commented Apr 30, 2016

I'll look at pulling ths in once we get the test task working again. Please stand by...

Issue: #152

@dorgan
Copy link
Collaborator

dorgan commented Apr 30, 2016

@marcobiedermann if you will update these to the latest current versions, I will go ahead and pull this in. Thank you for contributing!

@dorgan
Copy link
Collaborator

dorgan commented May 1, 2016

@drublic his checked we're failing because of bad code already in the module. (see commit that corrects bad code here)

@drublic
Copy link
Collaborator

drublic commented May 1, 2016

Thanks for fixing this @dorgan.

@marcobiedermann
Copy link
Author

@drublic @dorgan I've merged the updated master branch into my feature and updated all dependencies again. Hope, this will fit all your needs. If you got any more suggestions, feel free to hit me up :)

@dorgan
Copy link
Collaborator

dorgan commented May 1, 2016

@marcobiedermann looks like upgrading to latest dependencies breaks somethings as tests are failing.

@marcobiedermann
Copy link
Author

@dorgan When I run grunt test I get the following output:

Running "setup:test" (setup) task
Warning: Path must be a string. Received [ 'test/fixtures/component.json' ] Use --force to continue.

Honestly I do not have any idea how to solve this. I googled a bit but could not find the right answer.

@dorgan
Copy link
Collaborator

dorgan commented May 1, 2016

I'm actually working through this now. I've solved that problem as well as
another and now am working on the third, and then I believe there is a
fourth. Hopefully I'll be able to get these resolved soon.

On Sunday, May 1, 2016, Marco Biedermann notifications@github.com wrote:

@dorgan https://github.com/dorgan When I run grunt test I get the
following output:

Running "setup:test" (setup) task
Warning: Path must be a string. Received [ 'test/fixtures/component.json' ] Use --force to continue.

Honestly I do not have any idea how to solve this. I googled a bit but
could not find the right answer.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#151 (comment)

@dorgan
Copy link
Collaborator

dorgan commented May 1, 2016

Based on the complexities of the changes I am having to be compatible, this
will have to wait for the next release, as there will be breaking changes
in this.

On Sunday, May 1, 2016, Donald Organ dorgan@donaldorgan.com wrote:

I'm actually working through this now. I've solved that problem as well
as another and now am working on the third, and then I believe there is a
fourth. Hopefully I'll be able to get these resolved soon.

On Sunday, May 1, 2016, Marco Biedermann <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

@dorgan https://github.com/dorgan When I run grunt test I get the
following output:

Running "setup:test" (setup) task
Warning: Path must be a string. Received [ 'test/fixtures/component.json' ] Use --force to continue.

Honestly I do not have any idea how to solve this. I googled a bit but
could not find the right answer.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#151 (comment)

@moczolaszlo
Copy link

moczolaszlo commented May 5, 2016

Hi @dorgan and @marcobiedermann
I fixed the testes, all passed for me with the updated dependencies.
Tomorrow I will send a PR to this repo, ok?

@moczolaszlo
Copy link

Here: #156

@dorgan
Copy link
Collaborator

dorgan commented Jun 6, 2016

Resolved in #156

@dorgan dorgan closed this Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants