Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3324: Add OperationChainValidator to FedStore POC #3325

Merged
merged 8 commits into from
Oct 22, 2024

Conversation

cn337131
Copy link
Member

@cn337131 cn337131 commented Oct 21, 2024

Adds a custom OperationChainValidator that overrides getSchema to use the graph's merged schemas when handling Operation Chains.

Related issue

@cn337131 cn337131 added the federated-store Specific to/touches the federated-store module label Oct 21, 2024
@cn337131 cn337131 added this to the 2.4.0 milestone Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.90%. Comparing base (a5a67ac) to head (d5c0f42).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...le/operation/FederatedOperationChainValidator.java 60.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3325      +/-   ##
=============================================
- Coverage      67.90%   67.90%   -0.01%     
  Complexity      2597     2597              
=============================================
  Files            952      953       +1     
  Lines          30492    30498       +6     
  Branches        3363     3363              
=============================================
+ Hits           20707    20711       +4     
- Misses          8310     8312       +2     
  Partials        1475     1475              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@wb36499 wb36499 merged commit c8f0732 into develop Oct 22, 2024
26 of 28 checks passed
@wb36499 wb36499 deleted the gh-3324-fed-store-opchainvalidator branch October 22, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
federated-store Specific to/touches the federated-store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Federated store should have its own Operation Validator
4 participants