Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Federated store should have its own Operation Validator #3324

Closed
cn337131 opened this issue Oct 17, 2024 · 0 comments · Fixed by #3325
Closed

Federated store should have its own Operation Validator #3324

cn337131 opened this issue Oct 17, 2024 · 0 comments · Fixed by #3325
Labels
enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module
Milestone
2.4.0

Comments

@cn337131
Copy link
Member

Using the normal operation chain validator supplied by the store class is not adequate for federation as the schema is dependant on the options passed in the chain.

To get around this a custom validator should be added that extends the standard one but overrides any method that gets the schema to instead run an operation using the options on the chain its validating. This should get the correct merged schema to validate on.
@cn337131 cn337131 added enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module labels Oct 17, 2024
@cn337131 cn337131 added this to the 2.4.0 milestone Oct 17, 2024
@github-actions github-actions bot mentioned this issue Oct 21, 2024
Merged
tb06904 added a commit that referenced this issue Oct 22, 2024
@tb06904
Merge branch 'develop' into gh-3324-fed-store-opchainvalidator
d5c0f42
wb36499 pushed a commit that referenced this issue Oct 22, 2024
@cn337131 @tb06904
Gh-3324: Add OperationChainValidator to FedStore POC (#3325)
c8f0732 
* add validator

* add test

* checkstyle

* copyright

* javadoc

* fix

* exception test

---------

Co-authored-by: tb06904 <141412860+tb06904@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module
Projects
None yet
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

Gh-3324: Add OperationChainValidator to FedStore POC gchq/Gaffer
1 participant
@cn337131