Merge pull request #3 from gcc-mirror/master #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update code |
1 similar comment
|
Update code |
fxcoudert
pushed a commit
to fxcoudert/gcc
that referenced
this pull request
May 4, 2021
This addresses Issue gcc-mirror#32 by adjusting the nested function hack to use bit 1 rather than bit 2. NOTE: that Arm reserve both bits 0 and 1 for furture use, so that this is no less a hack than using bit 2 - but it might be a somewhat more compatible hack. Tested with the example in Issue gcc-mirror#32 (otherwise, there's no real change in the testsuite).
mablinov
pushed a commit
to mablinov/gcc
that referenced
this pull request
Oct 29, 2021
…r nested. This adds a descriptor-based implementation and then addresses Issue gcc-mirror#32 by adjusting the nested function hack to use bit 1 rather than bit 2. NOTE: that Arm reserve both bits 0 and 1 for furture use, so that this is no less a hack than using bit 2 - but it might be a somewhat more compatible hack. Tested with the example in Issue gcc-mirror#32 (otherwise, there's no real change in the testsuite).
mablinov
pushed a commit
to mablinov/gcc
that referenced
this pull request
Nov 10, 2021
…r nested. This adds a descriptor-based implementation and then addresses Issue gcc-mirror#32 by adjusting the nested function hack to use bit 1 rather than bit 2. NOTE: that Arm reserve both bits 0 and 1 for furture use, so that this is no less a hack than using bit 2 - but it might be a somewhat more compatible hack. Tested with the example in Issue gcc-mirror#32 (otherwise, there's no real change in the testsuite).
fxcoudert
pushed a commit
to fxcoudert/gcc
that referenced
this pull request
Nov 23, 2021
This addresses Issue gcc-mirror#32 by adjusting the nested function hack to use bit 1 rather than bit 2. NOTE: that Arm reserve both bits 0 and 1 for furture use, so that this is no less a hack than using bit 2 - but it might be a somewhat more compatible hack. Tested with the example in Issue gcc-mirror#32 (otherwise, there's no real change in the testsuite).
catap
pushed a commit
to catap/gcc
that referenced
this pull request
Feb 22, 2022
…r nested. This addresses Issue gcc-mirror#32 by adjusting the nested function hack to use bit 1. NOTE: that Arm reserve both bits 0 and 1 for furture use, so that this is still a hack. (cherry picked from commit eb558326dace69781e48bedafe16fd79aa27ca8b) (cherry picked from commit 3422978e480e66623a25e757634d20da0e132c0b)
catap
pushed a commit
to catap/gcc
that referenced
this pull request
May 3, 2023
…r nested. This addresses Issue gcc-mirror#32 by adjusting the nested function hack to use bit 1. NOTE: that Arm reserve both bits 0 and 1 for furture use, so that this is still a hack. (cherry picked from commit eb558326dace69781e48bedafe16fd79aa27ca8b) (cherry picked from commit 3422978e480e66623a25e757634d20da0e132c0b)
catap
pushed a commit
to catap/gcc
that referenced
this pull request
May 3, 2023
…r nested. This addresses Issue gcc-mirror#32 by adjusting the nested function hack to use bit 1. NOTE: that Arm reserve both bits 0 and 1 for furture use, so that this is still a hack. (cherry picked from commit eb558326dace69781e48bedafe16fd79aa27ca8b) (cherry picked from commit 3422978e480e66623a25e757634d20da0e132c0b)
catap
pushed a commit
to catap/gcc
that referenced
this pull request
May 3, 2023
…r nested. This addresses Issue gcc-mirror#32 by adjusting the nested function hack to use bit 1. NOTE: that Arm reserve both bits 0 and 1 for furture use, so that this is still a hack. (cherry picked from commit eb558326dace69781e48bedafe16fd79aa27ca8b) (cherry picked from commit 3422978e480e66623a25e757634d20da0e132c0b)
catap
pushed a commit
to catap/gcc
that referenced
this pull request
May 3, 2023
…r nested. This addresses Issue gcc-mirror#32 by adjusting the nested function hack to use bit 1. NOTE: that Arm reserve both bits 0 and 1 for furture use, so that this is still a hack. (cherry picked from commit eb558326dace69781e48bedafe16fd79aa27ca8b) (cherry picked from commit 3422978e480e66623a25e757634d20da0e132c0b)
catap
pushed a commit
to catap/gcc
that referenced
this pull request
May 3, 2023
…r nested. This addresses Issue gcc-mirror#32 by adjusting the nested function hack to use bit 1. NOTE: that Arm reserve both bits 0 and 1 for furture use, so that this is still a hack. (cherry picked from commit eb558326dace69781e48bedafe16fd79aa27ca8b) (cherry picked from commit 3422978e480e66623a25e757634d20da0e132c0b)
catap
pushed a commit
to catap/gcc
that referenced
this pull request
May 4, 2023
…r nested. This addresses Issue gcc-mirror#32 by adjusting the nested function hack to use bit 1. NOTE: that Arm reserve both bits 0 and 1 for furture use, so that this is still a hack. (cherry picked from commit eb558326dace69781e48bedafe16fd79aa27ca8b) (cherry picked from commit 3422978e480e66623a25e757634d20da0e132c0b)
catap
pushed a commit
to catap/gcc
that referenced
this pull request
May 4, 2023
…r nested. This addresses Issue gcc-mirror#32 by adjusting the nested function hack to use bit 1. NOTE: that Arm reserve both bits 0 and 1 for furture use, so that this is still a hack. (cherry picked from commit eb558326dace69781e48bedafe16fd79aa27ca8b) (cherry picked from commit 3422978e480e66623a25e757634d20da0e132c0b) Signed-off-by: Kirill A. Korinsky <kirill@korins.ky>
catap
pushed a commit
to catap/gcc
that referenced
this pull request
Nov 12, 2023
…r nested. This addresses Issue gcc-mirror#32 by adjusting the nested function hack to use bit 1. NOTE: that Arm reserve both bits 0 and 1 for furture use, so that this is still a hack. (cherry picked from commit eb558326dace69781e48bedafe16fd79aa27ca8b) (cherry picked from commit 3422978e480e66623a25e757634d20da0e132c0b) Signed-off-by: Kirill A. Korinsky <kirill@korins.ky>
nstester
pushed a commit
to nstester/gcc
that referenced
this pull request
Dec 11, 2023
…-int (PR target/112413)
On m68k the compiler assumes that the PC-relative jump-via-jump-table
instruction and the jump table are adjacent with no padding in between.
When -mlong-jump-table-offsets is combined with -malign-int, a 2-byte
nop may be inserted before the jump table, causing the jump to add the
fetched offset to the wrong PC base and thus jump to the wrong address.
Fixed by referencing the jump table via its label. On the test case
in the PR the object code change is (the moveal at 16 is the nop):
a: 6536 bcss 42 <f+0x42>
c: e588 lsll #2,%d0
e: 203b 0808 movel %pc@(18 <f+0x18>,%d0:l),%d0
- 12: 4efb 0802 jmp %pc@(16 <f+0x16>,%d0:l)
+ 12: 4efb 0804 jmp %pc@(18 <f+0x18>,%d0:l)
16: 284c moveal %a4,%a4
18: 0000 0020 orib gcc-mirror#32,%d0
1c: 0000 002c orib gcc-mirror#44,%d0
Bootstrapped and tested on m68k-linux-gnu, no regressions.
Note: I don't have commit rights to I would need assistance applying this.
PR target/112413
gcc/
* config/m68k/linux.h (ASM_RETURN_CASE_JUMP): For
TARGET_LONG_JUMP_TABLE_OFFSETS, reference the jump table
via its label.
* config/m68k/m68kelf.h (ASM_RETURN_CASE_JUMP): Likewise.
* config/m68k/netbsd-elf.h (ASM_RETURN_CASE_JUMP): Likewise.
cooljeanius
referenced
this pull request
in cooljeanius/gcc
Sep 19, 2024
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
cooljeanius
referenced
this pull request
in cooljeanius/gcc
Sep 19, 2024
Fix code scanning alert #32: Incorrect conversion between integer types
cooljeanius
referenced
this pull request
in cooljeanius/gcc
Sep 19, 2024
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
cooljeanius
referenced
this pull request
in cooljeanius/gcc
Sep 20, 2024
Fix code scanning alert #32: Incorrect conversion between integer types
iains
pushed a commit
to NinaRanns/gcc
that referenced
this pull request
Oct 29, 2024
Contracts nonattr p2900r11
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master