Trim whitespace from uri element text

[scpeters]

This copies the whitespace test from #359
but takes a narrower approach by only trimming
whitespace from <uri> element text.

Closes #322.

Signed-off-by: Steve Peters scpeters@openrobotics.org

[codecov-commenter]

Codecov Report

Merging #365 into sdf10 will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            sdf10     #365      +/-   ##
==========================================
+ Coverage   87.35%   87.36%   +0.01%     
==========================================
  Files          60       60              
  Lines        9207     9215       +8     
==========================================
+ Hits         8043     8051       +8     
  Misses       1164     1164              

Impacted Files	Coverage Δ
src/Material.cc	99.30% <100.00%> (+0.04%)	⬆️
src/parser.cc	78.50% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 805a185...286b459. Read the comment docs.

[chapulina]

only trimming whitespace from element text.

While working on an ign-sensors PR I needed the whitespace fix within a <topic> field: gazebosim/gz-sensors#33 (comment)

I think it's not safe to assume that only URIs need the fix. I wouldn't be surprised to see some of these around, for example:

<name>
    my_robot
</name>

[scpeters]

clicked the wrong button

[chapulina]

I hear you, but it still feels a bit too heavy-handed to modify every xml file like this

I hear you too, the other PR should affect performance. My main concern at the moment is to keep the behavior backward-compatible.

Maybe there's a less invasive way of doing it. Extending your approach to all string values, maybe? I haven't checked how this affects elements like pose... Does this work, for example?

<pose>
1
2
3
0.1
0.2
0.3
</pose>

[scpeters]

I hear you, but it still feels a bit too heavy-handed to modify every xml file like this

I hear you too, the other PR should affect performance. My main concern at the moment is to keep the behavior backward-compatible.

Maybe there's a less invasive way of doing it. Extending your approach to all string values, maybe? I haven't checked how this affects elements like pose... Does this work, for example?

<pose>
1
2
3
0.1
0.2
0.3
</pose>

I wrote that but then thought better of it but clicked "close with comment" by accident. I've since deleted it. I'm still thinking it through.

[scpeters]

closing in favor of #359