Make topics valid #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
iche033
reviewed
Jul 28, 2020
iche033
reviewed
Jul 28, 2020
There was a problem hiding this comment.
There are a few code check errors:
[test/integration/gpu_lidar_sensor_plugin.cc:793]: (style) Variable 'parent' is assigned a value that is never used.
./src/AirPressureSensor.cc:107: Lines should be <= 80 characters long [whitespace/line_length] [2]
Done processing ./src/AirPressureSensor.cc
./test/integration/logical_camera_plugin.cc:262: Lines should be <= 80 characters long [whitespace/line_length] [2]
./test/integration/logical_camera_plugin.cc:279: Lines should be <= 80 characters long [whitespace/line_length] [2]
Done processing ./test/integration/logical_camera_plugin.cc
Total errors found: 3
iche033
approved these changes
Jul 29, 2020
|
looks good to me. We'll need to wait for a new ign-transport7 release for CI to turn green |
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-sensors2 #33 +/- ##
=================================================
+ Coverage 61.88% 80.25% +18.36%
=================================================
Files 13 21 +8
Lines 942 2046 +1104
=================================================
+ Hits 583 1642 +1059
- Misses 359 404 +45
Continue to review full report at Codecov.
|
|
@osrf-jenkins run tests please |
iche033
added a commit
that referenced
this pull request
Sep 1, 2020
* mv hgignore Signed-off-by: claireyywang <clairewang@openrobotics.org> * add gitignore Signed-off-by: claireyywang <clairewang@openrobotics.org> * [ign-sensors2] Update BitBucket links (#10) * [ign-sensors2] Update BitBucket links Signed-off-by: Louise Poubel <louise@openrobotics.org> * [ign-sensors2] Update BitBucket links Signed-off-by: Louise Poubel <louise@openrobotics.org> * [ign-sensors2] Workflow updates (#20) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Make topics valid (#33) Signed-off-by: Louise Poubel <louise@openrobotics.org> * add noise to depth camera Signed-off-by: Ian Chen <ichen@osrfoundation.org> * 2.9.0 release prep Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix version numbers in config.hh (#42) Signed-off-by: Carlos Agüero <caguero@openrobotics.org> * ci fixes Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: claireyywang <clairewang@openrobotics.org> Co-authored-by: chapulina <lupoubel@hotmail.com> Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nate Koenig <nkoenig@users.noreply.github.com> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Carlos Agüero <caguero@osrfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires gazebosim/gz-transport#153
Addresses gazebosim/gz-sim#239