Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check World joints in checkJointParentChildNames #1189

Merged
merged 5 commits into from
Oct 20, 2022
Merged

Check World joints in checkJointParentChildNames #1189

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4e86c3e
Add test for //world/joint parent / child
scpeters Oct 15, 2022
c9e9558
Check World joints in checkJointParentChildNames
scpeters Oct 15, 2022
4de3d60
Improve coverage
scpeters Oct 15, 2022
d8d8cfd
Fix spelling: dosn't -> doesn't
scpeters Oct 18, 2022
d2779cf
Merge branch 'sdf13' into scpeters/check_world_joint_parent_child
scpeters Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/test/pyModel_TEST.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@ def test_default_construction(self):
self.assertEqual(errors[1].message(),
"PoseRelativeToGraph error: scope does not point to a valid graph.")

# model dosn't have graphs, so no names should exist in graphs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# model dosn't have graphs, so no names should exist in graphs
# model doesn't have graphs, so no names should exist in graphs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d8d8cfd

self.assertFalse(model.name_exists_in_frame_attached_to_graph(""));
self.assertFalse(model.name_exists_in_frame_attached_to_graph("link"));


def test_copy_construction(self):
model = Model()
Expand Down
4 changes: 4 additions & 0 deletions python/test/pyWorld_TEST.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ def test_default_construction(self):
self.assertEqual(errors[1].message(),
"PoseRelativeToGraph error: scope does not point to a valid graph.")

# world dosn't have graphs, so no names should exist in graphs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# world dosn't have graphs, so no names should exist in graphs
# world doesn't have graphs, so no names should exist in graphs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d8d8cfd

self.assertFalse(world.name_exists_in_frame_attached_to_graph(""));
self.assertFalse(world.name_exists_in_frame_attached_to_graph("link"));


def test_copy_construction(self):
world = World()
Expand Down
7 changes: 7 additions & 0 deletions src/Model_TEST.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,10 @@ TEST(DOMModel, Construction)
errors[1].Message().find(
"PoseRelativeToGraph error: scope does not point to a valid graph"))
<< errors[1];

// model dosn't have graphs, so no names should exist in graphs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// model dosn't have graphs, so no names should exist in graphs
// model doesn't have graphs, so no names should exist in graphs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d8d8cfd

EXPECT_FALSE(model.NameExistsInFrameAttachedToGraph(""));
EXPECT_FALSE(model.NameExistsInFrameAttachedToGraph("link"));
}

/////////////////////////////////////////////////
Expand Down Expand Up @@ -229,6 +233,9 @@ TEST(DOMModel, AddLink)
EXPECT_EQ(1u, model.LinkCount());
EXPECT_FALSE(model.AddLink(link));
EXPECT_EQ(1u, model.LinkCount());
// model dosn't have graphs, so no names should exist in graphs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// model dosn't have graphs, so no names should exist in graphs
// model doesn't have graphs, so no names should exist in graphs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d8d8cfd

EXPECT_FALSE(model.NameExistsInFrameAttachedToGraph(""));
EXPECT_FALSE(model.NameExistsInFrameAttachedToGraph("link1"));

model.ClearLinks();
EXPECT_EQ(0u, model.LinkCount());
Expand Down
7 changes: 7 additions & 0 deletions src/World_TEST.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@ TEST(DOMWorld, Construction)
EXPECT_NE(std::string::npos,
errors[1].Message().find(
"PoseRelativeToGraph error: scope does not point to a valid graph"));

// world dosn't have graphs, so no names should exist in graphs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// world dosn't have graphs, so no names should exist in graphs
// world doesn't have graphs, so no names should exist in graphs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d8d8cfd

EXPECT_FALSE(world.NameExistsInFrameAttachedToGraph(""));
EXPECT_FALSE(world.NameExistsInFrameAttachedToGraph("model1"));
}

/////////////////////////////////////////////////
Expand Down Expand Up @@ -384,6 +388,9 @@ TEST(DOMWorld, AddModel)
EXPECT_EQ(1u, world.ModelCount());
EXPECT_FALSE(world.AddModel(model));
EXPECT_EQ(1u, world.ModelCount());
// world dosn't have graphs, so no names should exist in graphs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// world dosn't have graphs, so no names should exist in graphs
// world doesn't have graphs, so no names should exist in graphs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d8d8cfd

EXPECT_FALSE(world.NameExistsInFrameAttachedToGraph(""));
EXPECT_FALSE(world.NameExistsInFrameAttachedToGraph("model1"));

world.ClearModels();
EXPECT_EQ(0u, world.ModelCount());
Expand Down