Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install python3-gz-math7 instead of ignition #1092

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

That ignition there messes up with the sed command we have searching for gz in the install tutorial:

https://github.com/gazebosim/docs/blob/master/garden/install_ubuntu_src.md#install-dependencies

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from JoanAguilar July 26, 2022 22:05
@chapulina chapulina requested review from azeey and scpeters as code owners July 26, 2022 22:05
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 26, 2022
@chapulina chapulina enabled auto-merge (squash) July 26, 2022 22:07
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #1092 (1d95bca) into main (e4f63fb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1092   +/-   ##
=======================================
  Coverage   83.10%   83.10%           
=======================================
  Files         155      155           
  Lines       18767    18767           
=======================================
  Hits        15596    15596           
  Misses       3171     3171           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4f63fb...1d95bca. Read the comment docs.

@chapulina chapulina merged commit 20e15e5 into main Jul 26, 2022
@chapulina chapulina deleted the chapulina/13/gz_math branch July 26, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants