Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install gz packages instead of ignition #1614

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Install gz packages instead of ignition #1614

merged 1 commit into from
Jul 27, 2022

Conversation

chapulina
Copy link
Contributor

Summary

That ignition there messes up with the sed command we have searching for gz in the install tutorial:

https://github.com/gazebosim/docs/blob/master/garden/install_ubuntu_src.md#install-dependencies

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #1614 (b7970f4) into main (a3cbd8c) will decrease coverage by 0.01%.
The diff coverage is 99.24%.

@@            Coverage Diff             @@
##             main    #1614      +/-   ##
==========================================
- Coverage   63.62%   63.61%   -0.02%     
==========================================
  Files         330      330              
  Lines       25787    25931     +144     
==========================================
+ Hits        16408    16495      +87     
- Misses       9379     9436      +57     
Impacted Files Coverage Δ
include/gz/sim/EventManager.hh 79.16% <ø> (ø)
include/gz/sim/Util.hh 100.00% <ø> (ø)
include/gz/sim/components/Serialization.hh 95.55% <ø> (ø)
include/gz/sim/components/Factory.hh 97.53% <80.00%> (-1.18%) ⬇️
include/gz/sim/EntityComponentManager.hh 100.00% <100.00%> (ø)
include/gz/sim/Link.hh 100.00% <100.00%> (ø)
include/gz/sim/Model.hh 100.00% <100.00%> (ø)
include/gz/sim/SdfEntityCreator.hh 100.00% <100.00%> (ø)
include/gz/sim/Server.hh 100.00% <100.00%> (ø)
include/gz/sim/ServerConfig.hh 100.00% <100.00%> (ø)
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eabad2d...b7970f4. Read the comment docs.

@chapulina chapulina merged commit f2f8eca into main Jul 27, 2022
@chapulina chapulina deleted the chapulina/7/gz_ci branch July 27, 2022 01:11
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants